Fix Coverity issues: resource leak and uncaught exceptions in destructors

CID 2984086 (RESOURCE_LEAK): In CreateCmDevice (Linux), device->m_dll was
loaded via so_load but not freed via so_free() before delete device in
error paths. Added so_free(device->m_dll) before each delete device.

CIDs 3558368, 3558369, 3558372, 3558379, 3558386, 3558389, 3558398
(UNCAUGHT_EXCEPT): MFX_STS_TRACE macro creates std::string objects that
can throw std::bad_alloc. Since destructors are implicitly noexcept, any
exception would call std::terminate(). Wrapped destructor bodies with
try-catch(...) to prevent exception propagation.

Affected destructors:
- mfxSurfaceVulkanImg2DImpl::~mfxSurfaceVulkanImg2DImpl
- SurfaceScopedLock::~SurfaceScopedLock
- vaapi_buffer_wrapper::~vaapi_buffer_wrapper
- vaapi_surface_wrapper::~vaapi_surface_wrapper
- mfxSurfaceVAAPIImpl::~mfxSurfaceVAAPIImpl
- VACopyWrapper::SurfaceWrapper::~SurfaceWrapper
- LinuxVideoAccelerator::~LinuxVideoAccelerator

Author: Gvence

_studio/mfx_lib/ext/cmrt_cross_platform/src/cmrt_cross_platform.cpp

@@ -521,13 +521,15 @@ INT CreateCmDevice(CmDevice *& pD, UINT & version, VADisplay va_dpy, UINT mode)
     CreateCmDeviceLinuxFuncTypeEx createFunc = (CreateCmDeviceLinuxFuncTypeEx)so_get_addr(device->m_dll, FUNC_NAME_CREATE_CM_DEVICE_EX);
     if (createFunc == 0)
     {
+        so_free(device->m_dll);
         delete device;
         return CM_FAILURE;
     }
 
     INT res = createFunc(device->m_linux, version, va_dpy, mode);
     if (res != CM_SUCCESS)
     {
+        so_free(device->m_dll);
         delete device;
         return CM_FAILURE;
     }

_studio/shared/include/libmfx_allocator_vaapi.h

@@ -78,8 +78,12 @@ class SurfaceScopedLock
 
     ~SurfaceScopedLock()
     {
-        if (m_mapped)        std::ignore = MFX_STS_TRACE(Unmap());
-        if (m_image_created) std::ignore = MFX_STS_TRACE(DestroyImage());
+        try
+        {
+            if (m_mapped)        std::ignore = MFX_STS_TRACE(Unmap());
+            if (m_image_created) std::ignore = MFX_STS_TRACE(DestroyImage());
+        }
+        catch (...) {}
     }
 
     mfxStatus DeriveImage()

_studio/shared/src/libmfx_allocator_vaapi.cpp

@@ -851,7 +851,11 @@ vaapi_buffer_wrapper::vaapi_buffer_wrapper(const mfxFrameInfo &info, VADisplayWr
 
 vaapi_buffer_wrapper::~vaapi_buffer_wrapper()
 {
-    std::ignore = MFX_STS_TRACE(vaDestroyBuffer(*m_pVADisplay, m_resource_id));
+    try
+    {
+        std::ignore = MFX_STS_TRACE(vaDestroyBuffer(*m_pVADisplay, m_resource_id));
+    }
+    catch (...) {}
 }
 
 mfxStatus vaapi_buffer_wrapper::Lock(mfxFrameData& frame_data, mfxU32 flags)
@@ -1066,10 +1070,14 @@ mfxStatus vaapi_surface_wrapper::CopyImportSurfaceVAAPI(const mfxFrameInfo& info
 
 vaapi_surface_wrapper::~vaapi_surface_wrapper()
 {
-    if (!m_imported)
+    try
     {
-        std::ignore = MFX_STS_TRACE(vaDestroySurfaces(*m_pVADisplay, &m_resource_id, 1));
+        if (!m_imported)
+        {
+            std::ignore = MFX_STS_TRACE(vaDestroySurfaces(*m_pVADisplay, &m_resource_id, 1));
+        }
     }
+    catch (...) {}
 }
 
 mfxStatus vaapi_surface_wrapper::Lock(mfxFrameData& frame_data, mfxU32 flags)
@@ -1304,16 +1312,20 @@ mfxSurfaceVAAPIImpl::mfxSurfaceVAAPIImpl(const mfxSurfaceHeader& export_header,
 
 mfxSurfaceVAAPIImpl::~mfxSurfaceVAAPIImpl()
 {
-    if (mfxSurfaceInterface::Header.SurfaceFlags & MFX_SURFACE_FLAG_EXPORT_COPY)
-    {
-        std::ignore = MFX_STS_TRACE(vaDestroySurfaces(*m_pVADisplay, &m_surface_id, 1));
-    }
-    // In reality excessive check, with correct refmanagement original surface should be alive
-    else if (GetParentSurface())
+    try
     {
-        // Release original surface, VASurfaceID can be destroyed now
-        GetParentSurface()->Release();
+        if (mfxSurfaceInterface::Header.SurfaceFlags & MFX_SURFACE_FLAG_EXPORT_COPY)
+        {
+            std::ignore = MFX_STS_TRACE(vaDestroySurfaces(*m_pVADisplay, &m_surface_id, 1));
+        }
+        // In reality excessive check, with correct refmanagement original surface should be alive
+        else if (GetParentSurface())
+        {
+            // Release original surface, VASurfaceID can be destroyed now
+            GetParentSurface()->Release();
+        }
     }
+    catch (...) {}
 }
 
 /* EOF */

_studio/shared/src/libmfx_core_vaapi.cpp

@@ -173,8 +173,12 @@ class VACopyWrapper
 
         ~SurfaceWrapper()
         {
-            if (m_id != VA_INVALID_SURFACE && m_bDestroySurface)
-                std::ignore = MFX_STS_TRACE(vaDestroySurfaces(m_dpy, &m_id, 1));
+            try
+            {
+                if (m_id != VA_INVALID_SURFACE && m_bDestroySurface)
+                    std::ignore = MFX_STS_TRACE(vaDestroySurfaces(m_dpy, &m_id, 1));
+            }
+            catch (...) {}
         }
 
         VASurfaceID GetId() const

_studio/shared/umc/io/umc_va/src/umc_va_linux.cpp

@@ -348,7 +348,11 @@ LinuxVideoAccelerator::LinuxVideoAccelerator(void)
 
 LinuxVideoAccelerator::~LinuxVideoAccelerator(void)
 {
-    Close();
+    try
+    {
+        Close();
+    }
+    catch (...) {}
 }
 
 Status LinuxVideoAccelerator::Init(VideoAcceleratorParams* pInfo)