fix(connectors): eliminate N+1 HTTP requests in MISP connector

Author: jagapathi20

api_app/connectors_manager/connectors/misp.py

@@ -62,8 +62,7 @@ def _base_attr_obj(self) -> pymisp.MISPAttribute:
             value = self._job.analyzable.name
             if _type == Classification.HASH:
                 matched_type = helpers.get_hash_type(value)
-                matched_type.replace("-", "")  # convert sha-x to shax
-                _type = matched_type if matched_type is not None else "text"
+                _type = matched_type.replace("-", "") if matched_type is not None else "text"
             else:
                 _type = INTELOWL_MISP_TYPE_MAP[_type]
 
@@ -119,13 +118,20 @@ def run(self):
         # append attribute name to event info
         event.info += f": {base_attr.value}"
 
-        # add event to MISP Instance
-        misp_event = misp_instance.add_event(event, pythonify=True)
-        # add attributes to event on MISP Instance
+        # bulk: attach all attributes to the event object before sending
         for attr in attributes:
-            misp_instance.add_attribute(misp_event.id, attr)
+            event.add_attribute(
+                attr.type,
+                attr.value,
+                **{k: v for k, v in attr.to_dict().items() if k not in ("type", "value", "uuid")},
+            )
+
+        # add event + all attributes in a single request (bulk optimization)
+        misp_event = misp_instance.add_event(event, pythonify=True)
+
+        result = misp_instance.get_event(misp_event.id)
 
-        return misp_instance.get_event(misp_event.id)
+        return result
 
     @classmethod
     def _monkeypatch(cls):