fix: non-breaking auto mod fix#1546
Merged
Merged
Conversation
silasary
reviewed
Aug 27, 2023
LordOfPolls
reviewed
Aug 29, 2023
LordOfPolls
approved these changes
Aug 31, 2023
Contributor
|
LGTM pinging @silasary before i merge, as she was looking at this too |
silasary
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Similar to #1543 but since the previous PR is breaking (and won't be merged before v6.0), the bugfix needed for #1540 has been added here in a non-breaking PR. Also, some docs, typehint and arguments modified (not breaking).
Changes
Related Issues
Test Scenarios
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files