fix: Hold running tasks within a Task, so the task doesn't get garbage collected before it completes#1790
Merged
Merged
Conversation
…e collected before it completes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1790 +/- ##
============================================
+ Coverage 46.53% 46.56% +0.03%
============================================
Files 149 149
Lines 16501 16504 +3
============================================
+ Hits 7678 7685 +7
+ Misses 8823 8819 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AstreaTSS
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
I noticed that one of my long-running tasks was never completing, and just kinda stopped silently after about an hour of execution. Upon some digging, I found the note in https://docs.python.org/3.10/library/asyncio-task.html#asyncio.create_task that asyncio uses weak references, and that the fire-and-forget method we're using is liable to garbage collection.
Changes
Related Issues
Test Scenarios
Currently testing in prod, will see if reliability goes up
Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files