Skip to content

Harden staged-publish workflow: fix ancestry guard, serialize releases, bound runtime #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
patocallaghan wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Draft

Harden staged-publish workflow: fix ancestry guard, serialize releases, bound runtime #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3ed2d1
Harden publish workflow: fix ancestry guard, serialize releases, boun…
patocallaghan Jun 10, 2026
05d4c4d
Trim verbose comments on the hardening changes
patocallaghan Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,18 @@ on:
permissions:
contents: read # workflow default (least privilege); only stage-publish also needs id-token, granted on that job

concurrency:
group: publish-${{ github.workflow }} # serialize publishes; no dist-tag races
cancel-in-progress: false # queue, don't kill an in-flight publish

jobs:
verify:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with: { persist-credentials: false }
with:
persist-credentials: false
fetch-depth: 0 # full history for the ancestry check below
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version-file: '.nvmrc' # pin >= 22.14.0
Expand All @@ -35,13 +41,13 @@ jobs:
RELEASE_TAG: ${{ github.event.release.tag_name }}
DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
run: |
git fetch origin "$DEFAULT_BRANCH" --depth=1
git merge-base --is-ancestor "$GITHUB_SHA" "origin/$DEFAULT_BRANCH" \
|| { echo "release $RELEASE_TAG not reachable from $DEFAULT_BRANCH — refusing"; exit 1; }

stage-publish:
needs: verify
runs-on: ubuntu-latest
timeout-minutes: 15 # cap a hung publish
permissions:
contents: read
id-token: write # OIDC trusted publishing: only this job mints the token
Expand Down