fix: set amount as zero fix typos

Author: nakul1010

crates/currency/src/lib.rs

@@ -116,7 +116,6 @@ pub mod pallet {
             + TryFrom<U256>
             + TryFrom<i64> // from bitcoin types
             + TryInto<i64> // into bitcoin types
-            + From<u128>
             + MaybeSerializeDeserialize
             + FullCodec
             + Copy

crates/issue/src/lib.rs

@@ -38,9 +38,9 @@ use currency::Amount;
 use frame_support::{dispatch::DispatchError, ensure, pallet_prelude::Weight, traits::Get, transactional, PalletId};
 use frame_system::{ensure_root, ensure_signed};
 pub use pallet::*;
-use primitives::{AccountOrVault, Balance};
+use primitives::AccountOrVault;
 use sp_core::H256;
-use sp_runtime::traits::{AccountIdConversion, Convert, Saturating, Zero};
+use sp_runtime::traits::{AccountIdConversion, Convert, Saturating};
 use sp_std::vec::Vec;
 use types::IssueRequestExt;
 use vault_registry::{types::CurrencyId, CurrencySource, VaultStatus};
@@ -366,9 +366,9 @@ impl<T: Config> Pallet<T> {
         let (griefing_collateral, fee, amount_user) = if requester.is_vault_account() {
             (
                 // for replace request griefing collateral remains as zero
-                Amount::new(Balance::zero().into(), griefing_currency),
+                Amount::zero(griefing_currency),
                 // for replace request fee remains as zero
-                Amount::new(Balance::zero().into(), vault_id.wrapped_currency()),
+                Amount::zero(vault_id.wrapped_currency()),
                 // for replace amount given to old_vault should be equal to specified amount
                 amount_requested.clone(),
             )

crates/redeem/src/lib.rs

@@ -629,10 +629,10 @@ impl<T: Config> Pallet<T> {
 
             (
                 fee_wrapped,
-                // the inclusion fee is paid by new vault itself hence we can set it as zero
+                // the inclusion fee is paid by old vault itself hence we can set it as zero
                 Amount::zero(vault_id.wrapped_currency()),
                 // the new vault (redeemer) should receive the whole amount without deduction of fees
-                // as fee handling is done by new vault itself
+                // as fee handling is done by old vault itself
                 amount_wrapped,
             )
         } else {