chore: upgrade to node v24 (#3854) (#3856)

Mwni · web-flow · commit c44d028fef1f · 2026-03-24T13:48:00.000+01:00
- Update .nvmrc
- Update engines in root package.json
- Update @types/node package
- Update all Dockerfiles to use node:24-alpine3.23
- Update workflows/rafiki/env-setup/action.yml to use Node 24
- Fix Invalid URL error (new URL("")) by filtering empty env string arrays
diff --git a/.github/workflows/rafiki/env-setup/action.yml b/.github/workflows/rafiki/env-setup/action.yml
@@ -7,7 +7,7 @@ runs:
     - uses: pnpm/action-setup@v3
     - uses: actions/setup-node@v4
       with:
-        node-version: '20'
+        node-version: '24'
         cache: 'pnpm'
     - name: Install dependencies
       shell: bash
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-lts/iron
+v24
diff --git a/localenv/mock-account-servicing-entity/Dockerfile b/localenv/mock-account-servicing-entity/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23 AS base
+FROM node:24-alpine3.23 AS base
 
 WORKDIR /home/rafiki
 
@@ -42,7 +42,7 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store \
     --frozen-lockfile
 RUN pnpm --filter mock-account-servicing-entity build
 
-FROM node:20-alpine3.23 AS runner
+FROM node:24-alpine3.23 AS runner
 
 WORKDIR /home/rafiki
 
diff --git a/localenv/mock-account-servicing-entity/package.json b/localenv/mock-account-servicing-entity/package.json
@@ -15,7 +15,7 @@
     "@remix-run/node": "^2.16.4",
     "@remix-run/react": "^2.16.4",
     "@remix-run/serve": "^2.16.4",
-    "@types/node": "^18.7.12",
+    "@types/node": "^24.0.0",
     "@types/uuid": "^9.0.8",
     "axios": "^1.12.0",
     "class-variance-authority": "^0.7.1",
@@ -38,6 +38,6 @@
     "tailwindcss": "^3.4.17"
   },
   "engines": {
-    "node": "20"
+    "node": "24"
   }
 }
diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
   "repository": "https://github.com/interledger/rafiki",
   "engines": {
     "pnpm": "^8.15.9",
-    "node": "20"
+    "node": "24"
   },
   "packageManager": "pnpm@8.15.9",
   "scripts": {
diff --git a/packages/auth/Dockerfile.dev b/packages/auth/Dockerfile.dev
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23
+FROM node:24-alpine3.23
 
 RUN adduser -D rafiki
 WORKDIR /home/rafiki
diff --git a/packages/auth/Dockerfile.prod b/packages/auth/Dockerfile.prod
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23 AS base
+FROM node:24-alpine3.23 AS base
 
 WORKDIR /home/rafiki
 
@@ -44,7 +44,7 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store \
     --frozen-lockfile
 RUN pnpm --filter auth build
 
-FROM node:20-alpine3.23 AS runner
+FROM node:24-alpine3.23 AS runner
 
 RUN adduser -D rafiki
 
diff --git a/packages/backend/Dockerfile.dev b/packages/backend/Dockerfile.dev
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23
+FROM node:24-alpine3.23
 
 RUN adduser -D rafiki
 WORKDIR /home/rafiki
diff --git a/packages/backend/Dockerfile.prod b/packages/backend/Dockerfile.prod
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23 AS base
+FROM node:24-alpine3.23 AS base
 
 WORKDIR /home/rafiki
 
@@ -44,7 +44,7 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store \
     --frozen-lockfile
 RUN pnpm --filter backend build
 
-FROM node:20-alpine3.23 AS runner
+FROM node:24-alpine3.23 AS runner
 
 # Since this is from a fresh image, we need to first create the Rafiki user
 RUN adduser -D rafiki
diff --git a/packages/backend/src/config/app.ts b/packages/backend/src/config/app.ts
@@ -14,7 +14,12 @@ function envString(name: string, defaultValue?: string): string {
 
 function envStringArray(name: string, value: string[]): string[] {
   const envValue = process.env[name]
-  return envValue == null ? value : envValue.split(',').map((s) => s.trim())
+  return envValue == null
+    ? value
+    : envValue
+        .split(',')
+        .map((s) => s.trim())
+        .filter((s) => s.length > 0)
 }
 
 function envInt(name: string, value: number): number {
diff --git a/packages/backend/src/payment-method/ilp/connector/core/utils/http-mocks.ts b/packages/backend/src/payment-method/ilp/connector/core/utils/http-mocks.ts
@@ -27,8 +27,10 @@ export class MockIncomingMessage extends Transform {
   complete = false
   connection!: Socket
   headers: IncomingHttpHeaders
+  headersDistinct: IncomingMessage['headersDistinct']
   rawHeaders: string[]
   trailers: { [key: string]: string | undefined } = {}
+  trailersDistinct: IncomingMessage['trailersDistinct'] = {}
   rawTrailers: string[] = []
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
@@ -74,12 +76,15 @@ export class MockIncomingMessage extends Transform {
 
     // Set header names
     this.headers = {}
+    this.headersDistinct = {}
     this.rawHeaders = []
     if (options.headers) {
       Object.keys(options.headers).forEach((key) => {
         const header = options.headers![key]
         if (header !== undefined) {
           this.headers[key.toLowerCase()] = header
+          this.headersDistinct[key.toLowerCase()] =
+            typeof header === 'string' ? [header] : header
           this.rawHeaders.push(key)
           this.rawHeaders.push(
             typeof header !== 'string' ? header.join(' ') : header
diff --git a/packages/card-service/Dockerfile.dev b/packages/card-service/Dockerfile.dev
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23
+FROM node:24-alpine3.23
 
 RUN adduser -D rafiki
 WORKDIR /home/rafiki
diff --git a/packages/card-service/Dockerfile.prod b/packages/card-service/Dockerfile.prod
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23 AS base
+FROM node:24-alpine3.23 AS base
 
 WORKDIR /home/rafiki
 
@@ -39,7 +39,7 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store \
     --frozen-lockfile
 RUN pnpm --filter card-service build
 
-FROM node:20-alpine3.23 AS runner
+FROM node:24-alpine3.23 AS runner
 
 # Since this is from a fresh image, we need to first create the Rafiki user
 RUN adduser -D rafiki
diff --git a/packages/card-service/package.json b/packages/card-service/package.json
@@ -29,7 +29,7 @@
     "@types/koa-bodyparser": "^4.3.12",
     "@types/koa__cors": "^5.0.0",
     "@types/koa__router": "^12.0.4",
-    "@types/node": "^20.14.15",
+    "@types/node": "^24.0.0",
     "@types/uuid": "^9.0.8",
     "jest-environment-node": "^29.7.0",
     "nock": "14.0.0-beta.19",
diff --git a/packages/frontend/Dockerfile.dev b/packages/frontend/Dockerfile.dev
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23 AS base
+FROM node:24-alpine3.23 AS base
 
 RUN adduser -D rafiki
 WORKDIR /home/rafiki
diff --git a/packages/frontend/Dockerfile.prod b/packages/frontend/Dockerfile.prod
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23 AS base
+FROM node:24-alpine3.23 AS base
 
 WORKDIR /home/rafiki
 
@@ -40,7 +40,7 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store \
     --frozen-lockfile
 RUN pnpm --filter frontend build
 
-FROM node:20-alpine3.23 AS runner
+FROM node:24-alpine3.23 AS runner
 RUN adduser -D rafiki
 WORKDIR /home/rafiki
 
diff --git a/packages/frontend/package.json b/packages/frontend/package.json
@@ -38,7 +38,7 @@
     "@remix-run/dev": "^2.16.4",
     "@remix-run/eslint-config": "^2.13.1",
     "@tailwindcss/forms": "^0.5.10",
-    "@types/node": "^20.12.5",
+    "@types/node": "^24.0.0",
     "@types/qs": "^6.14.0",
     "@types/react": "^18.2.73",
     "@types/react-dom": "^18.2.22",
@@ -52,6 +52,6 @@
     "tailwindcss": "^3.4.17"
   },
   "engines": {
-    "node": "20"
+    "node": "24"
   }
 }
diff --git a/packages/mock-account-service-lib/package.json b/packages/mock-account-service-lib/package.json
@@ -12,7 +12,7 @@
     "test": "jest"
   },
   "devDependencies": {
-    "@types/node": "^18.7.12",
+    "@types/node": "^24.0.0",
     "@types/uuid": "^9.0.8"
   },
   "dependencies": {
diff --git a/packages/point-of-sale/Dockerfile.dev b/packages/point-of-sale/Dockerfile.dev
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23
+FROM node:24-alpine3.23
 
 RUN adduser -D rafiki
 WORKDIR /home/rafiki
diff --git a/packages/point-of-sale/Dockerfile.prod b/packages/point-of-sale/Dockerfile.prod
@@ -1,4 +1,4 @@
-FROM node:20-alpine3.23 AS base
+FROM node:24-alpine3.23 AS base
 
 WORKDIR /home/rafiki
 
@@ -40,7 +40,7 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store \
     --frozen-lockfile
 RUN pnpm --filter point-of-sale build
 
-FROM node:20-alpine3.23 AS runner
+FROM node:24-alpine3.23 AS runner
 
 # Since this is from a fresh image, we need to first create the Rafiki user
 RUN adduser -D rafiki
diff --git a/packages/token-introspection/package.json b/packages/token-introspection/package.json
@@ -18,7 +18,7 @@
     "test:sincemain:cov": "pnpm test:sincemain --coverage"
   },
   "devDependencies": {
-    "@types/node": "^18.7.12",
+    "@types/node": "^24.0.0",
     "nock": "^13.5.6",
     "openapi-typescript": "^6.7.6"
   },
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/integration/package.json b/test/integration/package.json
diff --git a/test/test-lib/package.json b/test/test-lib/package.json

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM node:20-alpine3.23`
	`1`	`+FROM node:24-alpine3.23`
`2`	`2`
`3`	`3`	`RUN adduser -D rafiki`
`4`	`4`	`WORKDIR /home/rafiki`