chore!: removed 'updatedAt' from incoming and outgoing payments responses from OP by oana-lolea · Pull Request #3429 · interledger/rafiki

oana-lolea · 2025-05-13T13:19:12Z

Changes proposed in this pull request

Removed 'updatedAt' from incoming and outgoing payments responses, as well as from receiver.
Requires open-payments@7.0.0
Added feature #997

Context

Fixes #3386

Checklist

Related issues linked using fixes #number
Tests added/updated
Make sure that all checks pass
Bruno collection updated (if necessary)
Documentation issue created with user-docs label (if necessary)
OpenAPI specs updated (if necessary)

netlify · 2025-05-13T13:19:17Z

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name	Link
🔨 Latest commit	`4e10352`
🔍 Latest deploy log	https://app.netlify.com/projects/brilliant-pasca-3e80ec/deploys/6865006e1494dd0008c5e2cf

github-actions · 2025-05-13T13:24:05Z

🚀 Performance Test Results

Test Configuration:

VUs: 4
Duration: 1m0s

Test Metrics:

Requests/s: 43.93
Iterations/s: 14.66
Failed Requests: 0.00% (0 of 2643)

📜 Logs


> performance@1.0.0 run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 922 kB 15 kB/s
     data_sent......................: 1.9 MB 31 kB/s
     http_req_blocked...............: avg=6.36µs   min=2.38µs   med=5.11µs  max=611.83µs p(90)=6.23µs   p(95)=6.71µs  
     http_req_connecting............: avg=369ns    min=0s       med=0s      max=366.73µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=90.42ms  min=8.64ms   med=76.59ms max=693.14ms p(90)=149.34ms p(95)=173.2ms 
       { expected_response:true }...: avg=90.42ms  min=8.64ms   med=76.59ms max=693.14ms p(90)=149.34ms p(95)=173.2ms 
     http_req_failed................: 0.00%  ✓ 0         ✗ 2643
     http_req_receiving.............: avg=89.57µs  min=26.04µs  med=77.57µs max=1.75ms   p(90)=116.02µs p(95)=149.89µs
     http_req_sending...............: avg=37.03µs  min=9.11µs   med=26.88µs max=3.3ms    p(90)=38.3µs   p(95)=52.56µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=90.3ms   min=8.49ms   med=76.49ms max=693.04ms p(90)=149.25ms p(95)=173.06ms
     http_reqs......................: 2643   43.92993/s
     iteration_duration.............: avg=272.56ms min=181.61ms med=258.6ms max=988.89ms p(90)=326.82ms p(95)=350.87ms
     iterations.....................: 882    14.659931/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4

mkurapov · 2025-05-15T15:27:20Z

    "@graphql-tools/schema": "^10.0.16",
    "@interledger/http-signature-utils": "2.0.2",
-    "@interledger/open-payments": "6.13.2",
+    "@interledger/open-payments": "7.0.0",


Can you bump this in the auth package as well please

njlie · 2025-05-19T22:00:57Z

I think you just need to remove updatedAt in the query for getting a receiver in the Bruno collection. You also might need to remove some references to updatedAt to fix the integration tests.

…n for auth, test-lib and integration packages

mkurapov · 2025-06-02T10:56:46Z

I think this would end up fixing #3386 instead of #3337

mkurapov

Looks good, we should wait for #3337 to be merged in/completed first, then this one directly after

edit: 3386 -> 3337

oana-lolea · 2025-06-03T08:51:39Z

Looks good, we should wait for #3386 to be merged in/completed first, then this one directly after

@mkurapov, #3386 needs to use OP version 7.0.0, and it will break without 'updatedAt' removed.

mkurapov · 2025-06-03T11:49:12Z

@oana-lolea maybe you can open the 3337 PR against this one, and we'll merge it in as one?

…t limits (#3449) * Set limits to have either receive or debit amount * Updated auth limits and bruno request * Added the case when both types of amount are missing * Updated mock ASE consent screen, renamed error, added check in auth for both types of amount * Added error enum for access, added tests and updated types * Added error mapping for grants, updated tests * Format fixes and ignored eslint error * Updated createGrant function for testing * Forgot to rollback transaction when error will be thrown * Simplified access error handling * Removed unnecessary assert and changed error code * Fixed mock consent screen so it will support having either receive or debit amount * Updated consent messages * Updated mock ASE consent screen to handle all limit amount cases

…t from outgoing payments webhooks schema

Removed updatedAt from incoming and outgoing payments responses from OP

202ea4f

oana-lolea requested review from BlairCurrey, cozminu, golobitch, koekiebox, mkurapov, njlie and sanducb May 13, 2025 13:19

github-actions Bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels May 13, 2025

mkurapov added the breaking Issue/PR that introduces breaking changes label May 15, 2025

mkurapov changed the title ~~chore: removed 'updatedAt' from incoming and outgoing payments responses from OP~~ chore!: removed 'updatedAt' from incoming and outgoing payments responses from OP May 15, 2025

mkurapov reviewed May 15, 2025

View reviewed changes

Removed 'updatedAt' from test-lib 'createReceiver', updated OP versio…

e184ad5

…n for auth, test-lib and integration packages

github-actions Bot added the pkg: auth Changes in the GNAP auth package. label May 27, 2025

oana-lolea added 2 commits May 27, 2025 13:59

Updated pnpm-lock

53e8a82

Updated bruno requests

307f15d

mkurapov reviewed May 28, 2025

View reviewed changes

Comment thread packages/backend/src/open_payments/payment/incoming/model.ts

Removed 'updatedAt' from webhook.yaml

2fcadae

mkurapov previously approved these changes Jun 2, 2025

View reviewed changes

oana-lolea dismissed mkurapov’s stale review via 1e2c020 July 2, 2025 08:13

Merge branch 'main' into oana/raf-1044

a15a35a

oana-lolea requested a review from mkurapov July 2, 2025 08:59

mkurapov reviewed Jul 2, 2025

View reviewed changes

Comment thread packages/backend/src/openapi/specs/webhooks.yaml

Comment thread test/test-lib/package.json

Updated token-introspection OP version to 7.0.0, and removed updatedA…

4e10352

…t from outgoing payments webhooks schema

oana-lolea requested a review from mkurapov July 2, 2025 10:01

mkurapov approved these changes Jul 2, 2025

View reviewed changes

oana-lolea merged commit 16b501e into main Jul 2, 2025
44 checks passed

oana-lolea deleted the oana/raf-1044 branch July 2, 2025 10:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore!: removed 'updatedAt' from incoming and outgoing payments responses from OP#3429

chore!: removed 'updatedAt' from incoming and outgoing payments responses from OP#3429
oana-lolea merged 8 commits into
mainfrom
oana/raf-1044

oana-lolea commented May 13, 2025 •

edited

Loading

Uh oh!

netlify Bot commented May 13, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented May 13, 2025 •

edited

Loading

Uh oh!

mkurapov May 15, 2025

Uh oh!

njlie commented May 19, 2025

Uh oh!

Uh oh!

mkurapov commented Jun 2, 2025

Uh oh!

mkurapov left a comment •

edited

Loading

Uh oh!

oana-lolea commented Jun 3, 2025 •

edited

Loading

Uh oh!

mkurapov commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

oana-lolea commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this pull request

Context

Checklist

Uh oh!

netlify Bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Uh oh!

github-actions Bot commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Performance Test Results

Uh oh!

mkurapov May 15, 2025

Choose a reason for hiding this comment

Uh oh!

njlie commented May 19, 2025

Uh oh!

Uh oh!

mkurapov commented Jun 2, 2025

Uh oh!

mkurapov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oana-lolea commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkurapov commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

oana-lolea commented May 13, 2025 •

edited

Loading

netlify Bot commented May 13, 2025 •

edited

Loading

github-actions Bot commented May 13, 2025 •

edited

Loading

mkurapov left a comment •

edited

Loading

oana-lolea commented Jun 3, 2025 •

edited

Loading