chore: upgrade graphql#3445
Merged
Merged
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
BlairCurrey
commented
Jun 3, 2025
| "axios": "^1.8.2", | ||
| "class-variance-authority": "^0.7.1", | ||
| "graphql": "^16.8.1", | ||
| "graphql": "^16.11.0", |
Contributor
Author
There was a problem hiding this comment.
We talked about pining these everywhere. TBH I'm not sure if that's going to resolve it and feel like it makes it harder to keep everything up to date.
Contributor
|
Sanity check: making Admin API requests to local playground was OK? |
mkurapov
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
graphqlto latestContext
Somewhat resolves the issues encounter here where upgrading
graphqlindocumentationcauses another service to fail #3431.This issue was
authfailing to build when upgradinggraphqlto latest indocumentation.This "somewhat resolves" it because just upgrading the graphql package in documentation again could result in the same thing. We discussed pinning all the other graphql versions but I dont believe that was the issue. Even when reverting to 16.10 this still failed. Judging by the pnpm-lock for this commit the
graphql-armorwas using some hoisted version of 16.11.Maybe pinning the versions would prevent this but upgrading all versions seems like a good practice anyways.
Checklist
fixes #numberuser-docslabel (if necessary)