Skip to content

docs: edits to reduce vale errors#3873

Merged
melissahenderson merged 1 commit into
mainfrom
mh-vale
Mar 24, 2026
Merged

docs: edits to reduce vale errors#3873
melissahenderson merged 1 commit into
mainfrom
mh-vale

Conversation

@melissahenderson
Copy link
Copy Markdown
Contributor

@melissahenderson melissahenderson commented Mar 24, 2026

I used Rafiki as a test project to find and review suggestions and warnings thrown by Vale. I used this info to update Vale's rules (when possible/necessary) and to update Rafiki docs to prevent many suggestions/warnings from occurring on a page in the future.

  • [Y] Ran Prettier
  • [Y] Previewed updates in Netlify
  • [N/A] Included a "fixes #" comment

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 24, 2026

Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 4cd5fcb
🔍 Latest deploy log https://app.netlify.com/projects/brilliant-pasca-3e80ec/deploys/69c29ee3bc8b97000879d94f
😎 Deploy Preview https://deploy-preview-3873--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the pkg: documentation Changes in the documentation package. label Mar 24, 2026
@github-actions
Copy link
Copy Markdown

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 48.77
  • Iterations/s: 16.25
  • Failed Requests: 0.00% (0 of 2932)
📜 Logs

> performance@1.0.0 run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 1.1 MB 18 kB/s
     data_sent......................: 2.3 MB 38 kB/s
     http_req_blocked...............: avg=6.59µs   min=1.83µs   med=5.29µs   max=625.83µs p(90)=6.53µs   p(95)=7.15µs  
     http_req_connecting............: avg=517ns    min=0s       med=0s       max=596.69µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=81.41ms  min=7.03ms   med=65.43ms  max=528.95ms p(90)=138.32ms p(95)=167.1ms 
       { expected_response:true }...: avg=81.41ms  min=7.03ms   med=65.43ms  max=528.95ms p(90)=138.32ms p(95)=167.1ms 
     http_req_failed................: 0.00%  ✓ 0         ✗ 2932
     http_req_receiving.............: avg=87.37µs  min=28.61µs  med=79.45µs  max=2ms      p(90)=115.88µs p(95)=142.19µs
     http_req_sending...............: avg=35.21µs  min=8.69µs   med=28.11µs  max=1.6ms    p(90)=40.64µs  p(95)=54.49µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=81.28ms  min=6.88ms   med=65.3ms   max=528.87ms p(90)=138.25ms p(95)=166.96ms
     http_reqs......................: 2932   48.768759/s
     iteration_duration.............: avg=245.96ms min=159.94ms med=231.21ms max=799.35ms p(90)=308.79ms p(95)=341.24ms
     iterations.....................: 977    16.250708/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@melissahenderson melissahenderson requested review from brad-dow and hajjimo and removed request for brad-dow March 24, 2026 14:41
@melissahenderson
Copy link
Copy Markdown
Contributor Author

@hajjimo , @brad-dow These edits were to cut down on the number of flags thrown by Vale. I don't think the files need a review.

@melissahenderson melissahenderson merged commit 80fe1ca into main Mar 24, 2026
37 of 58 checks passed
@melissahenderson melissahenderson deleted the mh-vale branch March 24, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: documentation Changes in the documentation package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants