feat: prep for release v2.4.0-beta#3919
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
There was a problem hiding this comment.
Looks ok just had some non-blocking questions.
Why are the docs regenerated? If there are content differences I think this means the Spanish ones are out of date - is that accounted for anywhere (task to update?)
Whats the reason for doing the axios override? I realize this override pre-exists the PR and we are just updating it - I guess I'm asking more for my general knowledge. Is there a transitive dependency or something we are trying to control?
They do not automatically get built from the GraphQL schemas, so I built them manually. I will updating the links for Spanish one in a separate issue.
This is to fix the vulnerabilities listed in the description, making sure that the minimum version across all of the packages in the repo is an updated, non-vulnerable one via |
What I'm wondering is why it's an override and not just bumping the individual package versions. My understanding of overrides was that they were for forcing versions of packages we can't directly control ourselves. And ideally temporarily. But maybe we are intentionally using it to ensure the same version is used across packages? Im not sure that's a good idea. Pnpm has a catalog feature that can handle this and in their docs for it they directly state this would be misusing overrides: https://github.com/pnpm/rfcs/blob/main/text/0001-catalogs.md#comparison-to-overridesresolutions
The original override was Frankly IDK if we even need catalogs. We can just maintain the version directly across pacakges imo. We can still easily upgrade simultaneously with |
|
@BlairCurrey good point - for some reason I disregarded that we have it as a direct dependency, even though we do in a few of the packages. We should to do both: upgrade/pin the version across the dependencies, and also keep the override because there a few dependencies, mostly dev that have axios as a dependency themselves. Catalogs might be a great option for us in the rafiki-v2 repo, given the amount of packages we have. |
|
Made PR for upgrading and pinning axios version ☝️ |
Changes proposed in this pull request
Context
Fixes ROP-36
Checklist
fixes #numberuser-docslabel (if necessary)