feat(stripe): stripe payments now create a transaction in wallet (#1986)

* feat(stripe): add transactions for stripe payments

* fix(stripe): fix tests

* chore(stripe): format

Author: beniaminmunteanu

packages/wallet/backend/migrations/20250425115946_add_transaction_type.js

@@ -0,0 +1,46 @@
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+exports.up = function (knex) {
+  return knex.schema
+    .table('transactions', (table) => {
+      table.enum('source', ['Interledger', 'Stripe', 'Card'])
+    })
+    .then(() => {
+      return knex('transactions')
+        .update({ source: 'Card' })
+        .where({ isCard: true })
+    })
+    .then(() => {
+      return knex('transactions')
+        .update({ source: 'Interledger' })
+        .whereNull('source')
+    })
+    .then(() => {
+      return knex.schema.table('transactions', (table) => {
+        table.dropColumn('isCard')
+      })
+    })
+}
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+exports.down = function (knex) {
+  return knex.schema
+    .table('transactions', (table) => {
+      table.boolean('isCard').defaultTo(false)
+    })
+    .then(() => {
+      return knex('transactions')
+        .update({ isCard: true })
+        .where({ source: 'Card' })
+    })
+    .then(() => {
+      return knex.schema.table('transactions', (table) => {
+        table.dropColumn('source')
+      })
+    })
+}

packages/wallet/backend/src/gatehub/service.ts

@@ -166,7 +166,7 @@ export class GateHubService {
       type: 'OUTGOING',
       status: 'COMPLETED',
       description: '',
-      isCard: true
+      source: 'Card'
     })
   }
 

packages/wallet/backend/src/stripe-integration/service.ts

@@ -6,6 +6,8 @@ import { TransactionTypeEnum } from '../gatehub/consts'
 import { StripeWebhookType } from './validation'
 import { WalletAddressService } from '../walletAddress/service'
 import { AccountService } from '../account/service'
+import { Transaction } from '../transaction/model'
+import { transformBalance } from '../utils/helpers'
 
 export enum EventType {
   payment_intent_canceled = 'payment_intent.canceled',
@@ -68,6 +70,18 @@ export class StripeService implements IStripeService {
         type: TransactionTypeEnum.HOSTED,
         message: 'Stripe Transfer'
       })
+
+      await Transaction.query().insert({
+        walletAddressId: walletAddress.id,
+        accountId: walletAddress.accountId,
+        paymentId: paymentIntent.id,
+        assetCode: currency.toUpperCase(),
+        value: transformBalance(Number(amount), 2),
+        type: 'INCOMING',
+        status: 'COMPLETED',
+        description: 'Stripe Payment',
+        source: 'Stripe'
+      })
     } catch (error) {
       this.logger.error('Error creating gatehub transaction', { error })
       throw new BadRequest('Failed to create transaction')

packages/wallet/backend/src/transaction/model.ts

@@ -5,6 +5,7 @@ import { BaseModel } from '@shared/backend'
 import { TransactionResponse } from '@wallet/shared'
 
 export type TransactionType = 'INCOMING' | 'OUTGOING'
+export type TransactionSource = 'Interledger' | 'Stripe' | 'Card'
 export type TransactionExtended = Transaction & {
   walletAddressUrl: WalletAddress['url']
   accountName: Account['name']
@@ -31,7 +32,7 @@ export class Transaction
   assetCode!: string
   value!: bigint | null
   walletAddress!: WalletAddress
-  isCard?: boolean
+  source!: TransactionSource
   txAmount?: bigint
   txCurrency?: string
   conversionRate?: string

packages/wallet/backend/src/transaction/service.ts

@@ -1,4 +1,4 @@
-import { Transaction } from './model'
+import { Transaction, TransactionSource } from './model'
 import { OrderByDirection, Page, PartialModelObject } from 'objection'
 import { AccountService } from '@/account/service'
 import { Logger } from 'winston'
@@ -122,7 +122,7 @@ export class TransactionService implements ITransactionService {
     }
 
     const latestTransaction: Transaction | undefined = await Transaction.query()
-      .findOne({ accountId: account.id, isCard: true })
+      .findOne({ accountId: account.id, source: 'Card' })
       .orderBy('createdAt', 'DESC')
 
     const walletAddress = await WalletAddress.query().findOne({
@@ -171,7 +171,7 @@ export class TransactionService implements ITransactionService {
           type: 'OUTGOING',
           status: 'COMPLETED',
           description: '',
-          isCard: true,
+          source: 'Card' as TransactionSource,
           secondParty: transaction.merchantName,
           txAmount: transaction.transactionAmount
             ? transformBalance(Number(transaction.transactionAmount), 2)
@@ -229,7 +229,8 @@ export class TransactionService implements ITransactionService {
       value: amount.value,
       type: 'INCOMING',
       status: 'PENDING',
-      description: params.metadata?.description
+      description: params.metadata?.description,
+      source: 'Interledger'
     })
   }
 
@@ -256,7 +257,8 @@ export class TransactionService implements ITransactionService {
       status: 'PENDING',
       description: params.metadata?.description,
       secondParty: secondParty?.names,
-      secondPartyWA: secondParty?.walletAddresses
+      secondPartyWA: secondParty?.walletAddresses,
+      source: 'Interledger'
     })
   }
 }

packages/wallet/backend/tests/stripe-integration/service.test.ts

@@ -9,12 +9,21 @@ import { StripeService, EventType } from '@/stripe-integration/service'
 import { GateHubClient } from '@/gatehub/client'
 import { TransactionTypeEnum } from '@/gatehub/consts'
 import { StripeWebhookType } from '../../src/stripe-integration/validation'
+import { Transaction } from '@/transaction/model'
+import { Account } from '@/account/model'
+import { WalletAddress } from '@/walletAddress/model'
+import { loginUser } from '@/tests/utils'
+import { mockedListAssets } from '@/tests/mocks'
 
 describe('Stripe Service', (): void => {
   let bindings: AwilixContainer<Cradle>
   let appContainer: TestApp
   let knex: Knex
   let stripeService: StripeService
+  let userId: string
+  let account: Account
+  let walletAddress: WalletAddress
+  let walletId: string
 
   const mockGateHubClient = {
     createTransaction: jest.fn(),
@@ -78,6 +87,33 @@ describe('Stripe Service', (): void => {
   })
 
   beforeEach(async (): Promise<void> => {
+    // Necessary db setup for transaction creation
+    const { user } = await loginUser({
+      authService: await bindings.resolve('authService'),
+      extraUserArgs: {
+        isEmailVerified: true,
+        gateHubUserId: 'test-gatehub-user'
+      }
+    })
+    userId = user.id
+    walletId = faker.string.uuid()
+
+    account = await Account.query().insert({
+      name: faker.string.alpha(10),
+      userId: userId,
+      assetCode: 'USD',
+      assetId: mockedListAssets[0].id,
+      assetScale: 2,
+      gateHubWalletId: 'gatehub-wallet-123'
+    })
+
+    walletAddress = await WalletAddress.query().insert({
+      url: 'wallet_address_123',
+      publicName: 'Test Wallet',
+      accountId: account.id,
+      id: walletId
+    })
+
     Reflect.set(
       stripeService,
       'gateHubClient',
@@ -87,19 +123,12 @@ describe('Stripe Service', (): void => {
     Reflect.set(stripeService, 'walletAddressService', mockWalletAddressService)
     Reflect.set(stripeService, 'accountService', mockAccountService)
 
-    // Mock vault UUID lookup
     mockGateHubClient.getVaultUuid.mockReturnValue('vault-uuid-123')
 
-    // Mock successful transaction creation
     mockGateHubClient.createTransaction.mockResolvedValue(undefined)
 
-    // Mock wallet address lookup
-    mockWalletAddressService.getByUrl.mockResolvedValue({
-      id: 'wallet-123',
-      url: 'wallet_address_123'
-    })
+    mockWalletAddressService.getByUrl.mockResolvedValue(walletAddress)
 
-    // Mock gatehub wallet address lookup
     mockAccountService.getGateHubWalletAddress.mockResolvedValue({
       gateHubWalletId: 'gatehub-wallet-123'
     })
@@ -119,6 +148,19 @@ describe('Stripe Service', (): void => {
         type: TransactionTypeEnum.HOSTED,
         message: 'Stripe Transfer'
       })
+
+      const transactions = await Transaction.query()
+      expect(transactions).toHaveLength(1)
+      expect(transactions[0]).toMatchObject({
+        walletAddressId: walletAddress.id,
+        accountId: account.id,
+        paymentId: webhook.data.object.id,
+        assetCode: webhook.data.object.currency.toUpperCase(),
+        type: 'INCOMING',
+        status: 'COMPLETED',
+        description: 'Stripe Payment',
+        source: 'Stripe'
+      })
     })
 
     it('should handle payment_intent_payment_failed event type', async (): Promise<void> => {
@@ -135,6 +177,9 @@ describe('Stripe Service', (): void => {
         })
       )
       expect(mockGateHubClient.createTransaction).not.toHaveBeenCalled()
+
+      const transactions = await Transaction.query()
+      expect(transactions).toHaveLength(0)
     })
 
     it('should handle payment_intent_canceled event type', async (): Promise<void> => {
@@ -150,6 +195,9 @@ describe('Stripe Service', (): void => {
         })
       )
       expect(mockGateHubClient.createTransaction).not.toHaveBeenCalled()
+
+      const transactions = await Transaction.query()
+      expect(transactions).toHaveLength(0)
     })
 
     it('should log information about the received webhook', async (): Promise<void> => {
@@ -162,6 +210,9 @@ describe('Stripe Service', (): void => {
           `received webhook of type : ${webhook.type} for : ${webhook.id}`
         )
       )
+
+      const transactions = await Transaction.query()
+      expect(transactions).toHaveLength(1)
     })
   })
 
@@ -182,6 +233,19 @@ describe('Stripe Service', (): void => {
         type: TransactionTypeEnum.HOSTED,
         message: 'Stripe Transfer'
       })
+
+      const transactions = await Transaction.query()
+      expect(transactions).toHaveLength(1)
+      expect(transactions[0]).toMatchObject({
+        walletAddressId: walletAddress.id,
+        accountId: account.id,
+        paymentId: webhook.data.object.id,
+        assetCode: webhook.data.object.currency.toUpperCase(),
+        type: 'INCOMING',
+        status: 'COMPLETED',
+        description: 'Stripe Payment',
+        source: 'Stripe'
+      })
     })
 
     it('should throw error when GateHub transaction creation fails', async (): Promise<void> => {
@@ -204,6 +268,9 @@ describe('Stripe Service', (): void => {
           error: expect.any(Error)
         })
       )
+
+      const transactions = await Transaction.query()
+      expect(transactions).toHaveLength(0)
     })
   })
 
@@ -224,6 +291,9 @@ describe('Stripe Service', (): void => {
           error: webhook.data.object.last_payment_error
         })
       )
+
+      const transactions = await Transaction.query()
+      expect(transactions).toHaveLength(0)
     })
   })
 
@@ -243,6 +313,9 @@ describe('Stripe Service', (): void => {
           receiving_address: webhook.data.object.metadata.receiving_address
         })
       )
+
+      const transactions = await Transaction.query()
+      expect(transactions).toHaveLength(0)
     })
   })
 })