feat: FE part of registrations should be put back (#2115)

* Revert changes for registration hiding

* Update signup.tsx

Author: Tymmmy

packages/wallet/backend/src/app.ts

@@ -189,9 +189,7 @@ export class App {
     app.use(withSession)
 
     // Auth Routes
-    if (env.NODE_ENV !== 'production' || env.GATEHUB_ENV !== 'production') {
-      router.post('/signup', authController.signUp)
-    }
+    router.post('/signup', authController.signUp)
     router.post('/login', rateLimiterLogin, authController.logIn)
     router.post('/logout', isAuth, authController.logOut)
 

packages/wallet/frontend/src/pages/auth/index.tsx

@@ -4,7 +4,7 @@ import { NextPageWithLayout } from '@/lib/types/app'
 import { Button } from '@/ui/Button'
 import { Divider } from '@/ui/Divider'
 import { Link } from '@/ui/Link'
-import { FEATURES_ENABLED, THEME } from '@/utils/constants'
+import { THEME } from '@/utils/constants'
 import Image from 'next/image'
 
 const WelcomePage: NextPageWithLayout = () => {
@@ -20,19 +20,15 @@ const WelcomePage: NextPageWithLayout = () => {
       <Button aria-label="log in" href="auth/login">
         Log in
       </Button>
-      {!FEATURES_ENABLED ? (
-        <>
-          <Divider content="or" />
-          <h2 className="mb-5 text-xl font-semibold text-green dark:text-teal-neon">
-            New here?
-          </h2>
-          <Button aria-label="sign up" href="auth/signup">
-            Create account
-          </Button>
-        </>
-      ) : (
-        <Divider />
-      )}
+
+      <Divider content="or" />
+      <h2 className="mb-5 text-xl font-semibold text-green dark:text-teal-neon">
+        New here?
+      </h2>
+      <Button aria-label="sign up" href="auth/signup">
+        Create account
+      </Button>
+
       <Image
         className="mt-10 object-cover md:hidden"
         src={imageName}

packages/wallet/frontend/src/pages/auth/login.tsx

@@ -16,7 +16,7 @@ import { ErrorDialog } from '@/components/dialogs/ErrorDialog'
 import { NextPageWithLayout } from '@/lib/types/app'
 import { useEffect, useState } from 'react'
 import { loginSchema } from '@wallet/shared'
-import { FEATURES_ENABLED, THEME } from '@/utils/constants'
+import { THEME } from '@/utils/constants'
 
 const LoginPage: NextPageWithLayout = () => {
   const [openDialog, closeDialog] = useDialog()
@@ -158,14 +158,12 @@ const LoginPage: NextPageWithLayout = () => {
             />
           </button>
         </Form>
-        {!FEATURES_ENABLED ? (
-          <p className="mt-auto text-center font-extralight text-green dark:text-green-neon">
-            Not a customer?{' '}
-            <Link href="signup" className="font-medium underline">
-              Create an account
-            </Link>
-          </p>
-        ) : null}
+        <p className="mt-auto text-center font-extralight text-green dark:text-green-neon">
+          Not a customer?{' '}
+          <Link href="signup" className="font-medium underline">
+            Create an account
+          </Link>
+        </p>
       </div>
       <Image
         className="mt-10 object-cover md:hidden"

packages/wallet/frontend/src/pages/auth/signup.tsx

@@ -17,14 +17,12 @@ import { cx } from 'class-variance-authority'
 import { signUpSchema } from '@wallet/shared'
 import { FEATURES_ENABLED, THEME } from '@/utils/constants'
 import { Checkbox } from '@/ui/forms/Checkbox'
-import { useRouter } from 'next/router'
 
 const SignUpPage: NextPageWithLayout = () => {
   const [openDialog, closeDialog] = useDialog()
   const [isPasswordVisible, setPasswordVisible] = useState<boolean>(false)
   const [isRepeatPasswordVisible, setRepeatPasswordVisible] =
     useState<boolean>(false)
-  const router = useRouter()
 
   const signUpForm = useZodForm({
     schema: signUpSchema
@@ -36,9 +34,7 @@ const SignUpPage: NextPageWithLayout = () => {
     setRepeatPasswordVisible(!isRepeatPasswordVisible)
   }
   useEffect(() => {
-    FEATURES_ENABLED ? router.push('/auth/login') : null
     signUpForm.setFocus('email')
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [signUpForm])
 
   return (
@@ -136,28 +132,11 @@ const SignUpPage: NextPageWithLayout = () => {
           {FEATURES_ENABLED ? (
             <div className="relative cursor-pointer">
               <Checkbox
+                hidden
+                checked
                 {...signUpForm.register('acceptedCardTerms')}
                 error={signUpForm.formState.errors.acceptedCardTerms?.message}
-                label={
-                  <div>
-                    By clicking here, I confirm that I have read, understood,
-                    and agree with the&nbsp;
-                    <a
-                      className="underline"
-                      target="_blank"
-                      href="https://cdn.gatehub.net/docs/General_terms_for_Paywiser_x_GateHub-Mastercard_card_V1.pdf"
-                      rel="noreferrer"
-                    >
-                      Paywiser Terms and Conditions
-                    </a>
-                    &nbsp;for the use of the Paywiser MasterCard payment card,
-                    including the additional terms for card testing and
-                    limitations set out therein. I agree to not promote,
-                    advertise or post on any social media the Paywiser x GateHub
-                    MasterCard payment card without the prior written consent of
-                    the card issuer (Paywiser).
-                  </div>
-                }
+                label=""
               />
             </div>
           ) : null}