Skip to content

Commit d50071c

Browse files
DarianMdarian
andauthored
fix: windows compat issues with pnpm dev cmd & env var syntax (#1743)
* fix win compat issues with pnpm dev cmd and env var syntax * readme * add cross-env --------- Co-authored-by: darian <darian@interledger.org>
1 parent 24859d9 commit d50071c

4 files changed

Lines changed: 21 additions & 8 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ pnpm dev #this will start the project in hot reload mode for backend containers.
106106
other options to start the local env are:
107107

108108
```sh
109-
pnpm dev:debug #backend containers will not have hot reload feture enabled but will expose and have node `--inspect` option set with wallet container debug port set to 9229 and boutique port set to 9230. Once the containers are running, you can connect your debugger (e.g., Chrome DevTools, VS Code)
109+
pnpm dev:debug #backend containers will not have hot reload feature enabled but will expose and have node `--inspect` option set with wallet container debug port set to 9229 and boutique port set to 9230. Once the containers are running, you can connect your debugger (e.g., Chrome DevTools, VS Code)
110110
```
111111

112112
and:

package.json

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@
1616
"clean": "pnpm clean:modules && pnpm clean:builds",
1717
"clean:builds": "find . \\( -name \"dist\" -o -name \".next\" \\) -type d -prune -exec rm -rf '{}' +",
1818
"clean:modules": "find . -name 'node_modules' -type d -prune -exec rm -rf '{}' +",
19-
"dev": "pnpm localenv:start && concurrently -n 'WALLET,BOUTIQUE' -c blue.bold,red.bold 'pnpm wallet:frontend dev' 'pnpm boutique:frontend dev'",
20-
"dev:debug": "pnpm localenv:start:debug && concurrently -n 'WALLET,BOUTIQUE' -c blue.bold,red.bold 'pnpm wallet:frontend dev' 'pnpm boutique:frontend dev'",
21-
"dev:lite": "pnpm localenv:start:lite && concurrently -n 'WALLET,BOUTIQUE' -c blue.bold,red.bold 'pnpm wallet:frontend dev' 'pnpm boutique:frontend dev'",
19+
"dev": "pnpm localenv:start && concurrently -n \"WALLET,BOUTIQUE\" -c blue.bold,red.bold \"pnpm wallet:frontend dev\" \"pnpm boutique:frontend dev\"",
20+
"dev:debug": "pnpm localenv:start:debug && concurrently -n \"WALLET,BOUTIQUE\" -c blue.bold,red.bold \"pnpm wallet:frontend dev\" \"pnpm boutique:frontend dev\"",
21+
"dev:lite": "pnpm localenv:start:lite && concurrently -n \"WALLET,BOUTIQUE\" -c blue.bold,red.bold \"pnpm wallet:frontend dev\" \"pnpm boutique:frontend dev\"",
2222
"format": "pnpm prettier:write && pnpm lint:fix",
2323
"lint:check": "eslint --max-warnings=0 .",
2424
"lint:fix": "eslint --max-warnings=0 --fix .",
2525
"compose": "docker compose -f ./docker/dev/docker-compose.yml",
2626
"compose:prod": "docker compose -f ./docker/prod/docker-compose.yml",
27-
"localenv:start": "DEV_MODE=hot-reload pnpm compose up -d --build",
28-
"localenv:start:debug": "DEV_MODE=debug pnpm compose up -d --build",
29-
"localenv:start:lite": "DEV_MODE=lite pnpm compose up -d --build",
27+
"localenv:start": "cross-env DEV_MODE=hot-reload pnpm compose up -d --build",
28+
"localenv:start:debug": "cross-env DEV_MODE=debug pnpm compose up -d --build",
29+
"localenv:start:lite": "cross-env DEV_MODE=lite pnpm compose up -d --build",
3030
"localenv:stop": "pnpm compose down",
3131
"preinstall": "npx only-allow pnpm",
3232
"prettier:write": "prettier --config '.prettierrc.js' --write .",
@@ -43,6 +43,7 @@
4343
"@typescript-eslint/eslint-plugin": "^7.18.0",
4444
"@typescript-eslint/parser": "^7.18.0",
4545
"concurrently": "^9.0.1",
46+
"cross-env": "^7.0.3",
4647
"eslint": "^9.12.0",
4748
"eslint-config-prettier": "^9.1.0",
4849
"eslint-plugin-react": "^7.37.2",

packages/wallet/frontend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@wallet/frontend",
33
"scripts": {
4-
"dev": "PORT=4003 next dev",
4+
"dev": "next dev -p 4003",
55
"build:deps": "pnpm --filter @wallet/shared build",
66
"build": "pnpm build:deps && next build",
77
"start": "next start"

pnpm-lock.yaml

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)