chore(deps): update TypeScript to v6 (#1338)

Author: sidvishnoi

package.json

@@ -83,7 +83,7 @@
     "tailwindcss": "^3.4.19",
     "tinyspy": "^4.0.4",
     "totp-generator": "2.0.1",
-    "typescript": "^5.9.3"
+    "typescript": "^6.0.3"
   },
   "engines": {
     "pnpm": "^10.18.3",

pnpm-lock.yaml

@@ -52,22 +52,20 @@ export class Background {
     heartbeat,
     telemetry,
   }: Cradle) {
-    Object.assign(this, {
-      browser,
-      browserName,
-      walletService,
-      monetizationService,
-      storage,
-      sendToPopup,
-      sendToApp,
-      tabState,
-      tabEvents,
-      windowState,
-      logger,
-      events,
-      heartbeat,
-      telemetry,
-    });
+    this.browser = browser;
+    this.browserName = browserName;
+    this.walletService = walletService;
+    this.monetizationService = monetizationService;
+    this.storage = storage;
+    this.sendToPopup = sendToPopup;
+    this.sendToApp = sendToApp;
+    this.tabState = tabState;
+    this.tabEvents = tabEvents;
+    this.windowState = windowState;
+    this.logger = logger;
+    this.events = events;
+    this.heartbeat = heartbeat;
+    this.telemetry = telemetry;
   }
 
   async start() {
@@ -219,10 +217,8 @@ export class Background {
   }
 
   // TODO: type ReturnType based on message
-  onMessage = async (
-    message: ToBackgroundMessage,
-    sender: Runtime.MessageSender,
-  ) => {
+  onMessage = async (msg: unknown, sender: Runtime.MessageSender) => {
+    const message = msg as ToBackgroundMessage;
     this.logger.debug('Received message', message.action, message.payload);
     try {
       switch (message.action) {
@@ -511,7 +507,9 @@ export class Background {
     }
 
     const allTabs = await this.browser.tabs.query({});
-    const tabs = allTabs.filter((t) => t.id && t.url && isSecureContext(t.url));
+    const tabs = allTabs.filter(
+      (t) => t.id && t.url && isSecureContext(t.url),
+    ) as Tab[];
     const injectPolyfill = (tab: Tab) => {
       return this.browser.scripting.executeScript({
         target: { tabId: tab.id },

src/background/services/background.ts

@@ -1,6 +1,7 @@
 import type { Cradle } from '../container';
 
-type AsyncFn<T> = (...args: unknown[]) => Promise<T>;
+// biome-ignore lint/suspicious/noExplicitAny: as intended
+type AsyncFn<T> = (...args: any[]) => Promise<T>;
 
 interface CacheEntry<T> {
   promise: Promise<T>;
@@ -18,7 +19,7 @@ export class Deduplicator {
   private cache: Map<string, CacheEntry<unknown>> = new Map();
 
   constructor({ logger }: Pick<Cradle, 'logger'>) {
-    Object.assign(this, { logger });
+    this.logger = logger;
   }
 
   dedupe<T>(

src/background/services/deduplicator.ts

@@ -61,6 +61,7 @@ export class EventsService extends EventEmitter {
    * @deprecated
    */
   removeListener(): this {
+    // @ts-expect-error
     // biome-ignore lint/complexity/noArguments: it's cleaner and simpler
     return super.removeListener.apply(this, arguments);
   }

src/background/services/events.ts

@@ -4,7 +4,7 @@ export class Heartbeat {
   private browser: Cradle['browser'];
 
   constructor({ browser }: Cradle) {
-    Object.assign(this, { browser });
+    this.browser = browser;
   }
 
   start() {

src/background/services/heartbeat.ts

@@ -46,7 +46,10 @@ export class KeyAutoAddService {
     telemetry,
     t,
   }: Pick<Cradle, 'browser' | 'storage' | 'telemetry' | 't'>) {
-    Object.assign(this, { browser, storage, telemetry, t });
+    this.browser = browser;
+    this.storage = storage;
+    this.telemetry = telemetry;
+    this.t = t;
   }
 
   async addPublicKeyToWallet(
@@ -134,10 +137,8 @@ export class KeyAutoAddService {
       });
     };
 
-    const onMessageListener: OnPortMessageListener = (
-      message: KeyAutoAddToBackgroundMessage,
-      port,
-    ) => {
+    const onMessageListener: OnPortMessageListener = (msg: unknown, port) => {
+      const message = msg as KeyAutoAddToBackgroundMessage;
       if (message.action === 'SUCCESS') {
         removeListeners();
         this.telemetry.capture('key_auto_add_success', {