Skip to content

fix(background): avoid duplicate polyfill script warning#1030

Merged
sidvishnoi merged 2 commits into
mainfrom
polyfill-error-already-registered
Apr 29, 2025
Merged

fix(background): avoid duplicate polyfill script warning#1030
sidvishnoi merged 2 commits into
mainfrom
polyfill-error-already-registered

Conversation

@sidvishnoi

@sidvishnoi sidvishnoi commented Apr 25, 2025

Copy link
Copy Markdown
Member

Context

On browser start, there was a warning that the polyfill script was already registered.
Also, this warning was incorrectly included in the "Content script execution world MAIN not supported by your browser" warning.

image

Changes proposed in this pull request

  • Set persistAcrossSessions: false to prevent error in first place and for consistency with other content scripts.
  • Silence duplicate script error (different browsers may have different error message)

@sidvishnoi sidvishnoi requested a review from DarianM April 25, 2025 09:01
@github-actions github-actions Bot added the area: background Improvements or additions to extension background script label Apr 25, 2025
@github-actions

github-actions Bot commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Extension builds preview

Name Link
Latest commit 6a44d9b
Latest job logs Run #14733010630
Chrome (990.2KB)Download
Firefox (990.23KB)Download

@sidvishnoi sidvishnoi merged commit d64627b into main Apr 29, 2025
@sidvishnoi sidvishnoi deleted the polyfill-error-already-registered branch April 29, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: background Improvements or additions to extension background script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants