Skip to content

feat: support MMAON wallet#1034

Merged
sidvishnoi merged 22 commits into
mainfrom
wallet-mmaon
Oct 17, 2025
Merged

feat: support MMAON wallet#1034
sidvishnoi merged 22 commits into
mainfrom
wallet-mmaon

Conversation

@sidvishnoi
Copy link
Copy Markdown
Member

@sidvishnoi sidvishnoi commented Apr 28, 2025

Context

Closes #1029

Changes proposed in this pull request

  • MMAON uses GateHub wallet addresses behind the scenes, but with a proxy on own domain.
  • Add keyAutoAdd script for MMAON
  • Add basic E2E tests and setup CI to support that; but disable them for now
    • The staging env doesn't fully work yet due to some GateHub blockers, but works well in production, but we don't test there.

Follow up: #1050 (right now, we don't test full connect as we can't yet - upstream issue).

@github-actions github-actions Bot added area: content Improvements or additions to extension content script area: background Improvements or additions to extension background script area: ci Improvements or additions to repository workflows area: tests Improvements or additions to tests area: shared Changes to shared libraries and utilities labels Apr 28, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2025

Extension builds preview

Name Link
Latest commit b218da5
Latest job logs Run #18596002932
Chrome (1008.35KB)Download
Firefox (1008.37KB)Download
Safari (1.93MB)Download

@github-actions github-actions Bot removed the area: shared Changes to shared libraries and utilities label May 5, 2025
sidvishnoi

This comment was marked as duplicate.

Copy link
Copy Markdown
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e
(had wrong config (wrong CI variable name) in GitHub env)

Copy link
Copy Markdown
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e
Passing locally lol.

@sidvishnoi
Copy link
Copy Markdown
Member Author

This explains why tests failing 😆🤦🏽

image

@sidvishnoi sidvishnoi requested review from DarianM and removed request for DarianM October 17, 2025 09:59
Copy link
Copy Markdown
Member

@DarianM DarianM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key auto add works in prod

@sidvishnoi sidvishnoi merged commit 0ef918a into main Oct 17, 2025
11 checks passed
@sidvishnoi sidvishnoi deleted the wallet-mmaon branch October 17, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: background Improvements or additions to extension background script area: ci Improvements or additions to repository workflows area: content Improvements or additions to extension content script area: tests Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support MMAON as wallet

2 participants