Skip to content

refactor(bg/PaymentSession): improve constructor interface#1047

Merged
sidvishnoi merged 1 commit into
mainfrom
paymentSession-constructor
May 1, 2025
Merged

refactor(bg/PaymentSession): improve constructor interface#1047
sidvishnoi merged 1 commit into
mainfrom
paymentSession-constructor

Conversation

@sidvishnoi

@sidvishnoi sidvishnoi commented May 1, 2025

Copy link
Copy Markdown
Member

Context

Extracted from #1046.

Changes proposed in this pull request

  • Improve constructor interface (add that Cradle thing there, to keep DI-like dependencies together)
  • Improve some types
  • Some loop nits

@sidvishnoi sidvishnoi requested a review from DarianM May 1, 2025 12:32
@github-actions github-actions Bot added the area: background Improvements or additions to extension background script label May 1, 2025
@github-actions

github-actions Bot commented May 1, 2025

Copy link
Copy Markdown
Contributor

Extension builds preview

Name Link
Latest commit a0bbdad
Latest job logs Run #14775410214
Chrome (990.2KB)Download
Firefox (990.23KB)Download

@sidvishnoi sidvishnoi merged commit e71d3aa into main May 1, 2025
@sidvishnoi sidvishnoi deleted the paymentSession-constructor branch May 1, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: background Improvements or additions to extension background script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants