fix(shared/helpers): don't cache errors in memoize#1070
Merged
Conversation
github-actions
Bot
added
area: tests
Contributor
Extension builds preview
|
sidvishnoi
force-pushed
the
memoize-do-not-cache-errors
branch
from
83ee90b to
3857df1
Compare
DarianM
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
With
getExchangeRatesMemoized, sometimes there was an error in thegetExchangeRatescall. In that case, the cached result didn't have the expected type, as we had actually cached the rejected promise. So,convertWithExchangeRatewas erroring asexchangeRatesdidn't have.rates.Noticed while working on #1066.
Changes proposed in this pull request
memoize.Eventually, I think we'll remove the
Deduplicatorclass/service in favor of this helper.