fix(ConnectWalletForm): connect with fetched wallet info only#1088
Merged
Conversation
github-actions
Bot
added
area: background
sidvishnoi
commented
Jun 11, 2025
Comment on lines
+251
to
+252
| walletAddressInfo ?? | ||
| (await getWalletInfo(toWalletAddressUrl(walletAddress))), |
Member
Author
There was a problem hiding this comment.
walletAddressInfo should not be null here, but if it is, then we fetch it.
#957 should help avoid problems like this.
Contributor
Extension builds preview
|
DarianM
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #1083
Changes proposed in this pull request
Reuse fetched wallet info to connect the wallet, instead of fetching again in background (which might resolve to different wallet info).
Also gives a little performance benefit.