Skip to content

fix(shared/helpers): support /.well-known/pay payment pointers#1089

Merged
DarianM merged 6 commits into
mainfrom
better-pp-parsing
Jun 12, 2025
Merged

fix(shared/helpers): support /.well-known/pay payment pointers#1089
DarianM merged 6 commits into
mainfrom
better-pp-parsing

Conversation

@sidvishnoi
Copy link
Copy Markdown
Member

Context

Closes #1087

Changes proposed in this pull request

Now we can enter $mywebsite.com as wallet address when connecting wallet. mywebsite.com has configured their wallet address route at https://mywebsite.com/.well-known/pay, as defined by https://paymentpointers.org/syntax/

As an example, try $sidvishnoi.com.

@sidvishnoi sidvishnoi requested a review from DarianM June 11, 2025 13:31
@github-actions github-actions Bot added area: tests Improvements or additions to tests area: shared Changes to shared libraries and utilities labels Jun 11, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 11, 2025

Extension builds preview

Name Link
Latest commit a9ac350
Latest job logs Run #15606533415
Chrome (991.9KB)Download
Firefox (991.93KB)Download

Comment thread src/shared/helpers/wallet.ts Outdated
@sidvishnoi
Copy link
Copy Markdown
Member Author

Just saw CI for unit tests says no tests found 😬
Idk since when. I'll investigate tomorrow.

@sidvishnoi
Copy link
Copy Markdown
Member Author

Fixing tests and adding another test..

@DarianM
Copy link
Copy Markdown
Member

DarianM commented Jun 12, 2025

A small blog post about this 💯 !

@DarianM DarianM merged commit c7d2a6e into main Jun 12, 2025
9 checks passed
@DarianM DarianM deleted the better-pp-parsing branch June 12, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: shared Changes to shared libraries and utilities area: tests Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow using custom domains when connecting wallet

2 participants