fix(PayWebsiteForm): set min send amount based on wallets involved#1099
Merged
Conversation
github-actions
Bot
added
area: background
Contributor
Extension builds preview
|
sidvishnoi
requested changes
Jun 17, 2025
Collaborator
Author
|
Thank you for review @sidvishnoi, I'll make those changes today. One more thing I was wondering when making the change here in async getPopupData(tab: Pick<Tabs.Tab, 'id' | 'url'>): Promise<PopupStore>I noticed in storage there does exist |
Member
It doesn't exist anymore with #1085. Storage is about more permanent things. |
Collaborator
Author
|
@sidvishnoi I've went ahead and made some of the changes that were previously requested. Wrapping up local testing. |
sidvishnoi
requested changes
Jun 18, 2025
sidvishnoi
changed the title
kjmitchelljr
force-pushed
the
bugfix/issue-1071-fix-min-send-amount
branch
from
cbff92d to
882a43f
Compare
…other minor updates
nit: move type above for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #1071
Changes proposed in this pull request
Removes the hard coded value of $0.02 in the Pay Website Form for the minimum amount.
The change should reflect the currency of the wallet for the minimum payment to send.