Skip to content

refactor(shared/components): remove forwardRef, unused files#1151

Merged
sidvishnoi merged 1 commit into
mainfrom
react-cleanup
Aug 5, 2025
Merged

refactor(shared/components): remove forwardRef, unused files#1151
sidvishnoi merged 1 commit into
mainfrom
react-cleanup

Conversation

@sidvishnoi

@sidvishnoi sidvishnoi commented Aug 4, 2025

Copy link
Copy Markdown
Member

Context

Changes proposed in this pull request

  • Use ref in props instead of forwardRef
    • Note to reviewer: some files now have one-less indentation due to this. Ignore whitespace changes.
  • Remove unused components (Slider, WarningMessage)

@sidvishnoi sidvishnoi requested a review from DarianM August 4, 2025 13:12
@github-actions github-actions Bot added area: tests Improvements or additions to tests area: pages Changes to any of extension's pages labels Aug 4, 2025
@github-actions

github-actions Bot commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Extension builds preview

Name Link
Latest commit 75fed10
Latest job logs Run #16724135793
Chrome (997.25KB)Download
Firefox (997.27KB)Download
Safari (1.92MB)Download

@sidvishnoi sidvishnoi merged commit 1113be3 into main Aug 5, 2025
17 of 18 checks passed
@sidvishnoi sidvishnoi deleted the react-cleanup branch August 5, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: pages Changes to any of extension's pages area: tests Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants