fix: support force disconnect wallet in case of error#1166
Merged
Conversation
github-actions
Bot
added
area: background
Contributor
Extension builds preview
|
DarianM
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #1162
Changes proposed in this pull request
When there are issues with disconnecting wallet, show user an error and allow force disconnecting.
The error is only shown when disconnecting from WalletInfo page. On keyRevoked error page, I decided to enable
forceby default to not add new UI.Note: When we do a force disconnect, the access token isn't revoked from wallet end. We just delete it from our local storage (forget about it), so the user can move forward with their life. Hence, there can be dangling grants shown in wallet UI.
I considered adding a job queue for when things fail and doing them later on, but it had issues with authentication (in case client changed after a reconnect etc.). So, decided to keep it simple.