Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions biome.jsonc
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/2.1.3/schema.json",
"$schema": "https://biomejs.dev/schemas/2.2.4/schema.json",
"vcs": {
"enabled": true,
"clientKind": "git",
Expand Down Expand Up @@ -41,42 +41,45 @@
"useSingleVarDeclarator": "error",
"noUnusedTemplateLiteral": "error",
"useNumberNamespace": "error",
"noInferrableTypes": "error"
"noInferrableTypes": "error",
"useGroupedAccessorPairs": "error",
"useNumericSeparators": "error",
"useSymbolDescription": "error"
},
"suspicious": {
"noConsole": "warn"
"recommended": true,
"noConsole": "warn",
"noConstantBinaryExpressions": "error",
"noUnassignedVariables": "error",
"noUnknownAtRules": "off"
},
"correctness": {
"noUnusedVariables": "warn",
"noUnusedImports": "error",
"useImportExtensions": "off"
"useImportExtensions": "off",
"noNestedComponentDefinitions": "off",
"noReactPropAssignments": "error",
"noRestrictedElements": "error",
"useSingleJsDocAsterisk": "error",
"useJsonImportAttributes": "off",
"useUniqueElementIds": "info"
},
"a11y": {
"noSvgWithoutTitle": "off"
},
"performance": {
"recommended": true,
"noAwaitInLoops": "off" // TODO: turn on, too many cases
},
"nursery": {
"recommended": true,
"noAwaitInLoop": "off", // TODO: turn on, too many cases
"noFloatingPromises": "error",
"noMisusedPromises": "error",
"noConstantBinaryExpression": "error",
"useAdjacentGetterSetter": "error",
"noImportCycles": "off", // TODO: enable some time, too many cases right now.
"noNestedComponentDefinitions": "off", // TODO: turn on
"noReactPropAssign": "error",
"noRestrictedElements": "error",
"noShadow": "off", // TODO: turn on, too many cases
"noTsIgnore": "error",
"noUnassignedVariables": "error",
"noUselessBackrefInRegex": "error",
"noUselessEscapeInString": "error",
"noUselessUndefined": "error",
"noUnknownAtRule": "off", // tailwind
"useExplicitType": "off", // TODO: check if we want to. way too many cases
"useNumericSeparators": "error",
"useSingleJsDocAsterisk": "error",
"useSortedClasses": "off", // TODO: turn on
"useSymbolDescription": "error"
"useSortedClasses": "off" // TODO: turn on
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"wouter": "^3.7.1"
},
"devDependencies": {
"@biomejs/biome": "2.1.3",
"@biomejs/biome": "2.2.4",
"@jgoz/esbuild-plugin-typecheck": "^4.0.3",
"@jgoz/jest-esbuild": "^1.0.9",
"@octokit/openapi-webhooks-types": "^12.0.3",
Expand Down
76 changes: 38 additions & 38 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/pages/popup/components/ConnectWalletForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ export const ConnectWalletForm = ({
<ErrorMessage error={errors.connect.message} className="my-0" />
)}

{/** biome-ignore lint/correctness/useUniqueElementIds: referenced as stable ID */}
<Input
type="text"
label={t('connectWallet_label_walletAddress')}
Expand Down Expand Up @@ -502,6 +503,7 @@ function AmountInput({
const t = useTranslation();

return (
// biome-ignore lint/correctness/useUniqueElementIds: referenced as stable ID
<InputAmount
id="connectAmount"
label={t('connectWallet_label_amount')}
Expand Down
1 change: 1 addition & 0 deletions src/pages/popup/components/OutOfFunds.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export function AddFunds({
disabled
/>

{/** biome-ignore lint/correctness/useUniqueElementIds: referenced as stable ID */}
<InputAmount
id="amount_outOfFunds"
walletAddress={info}
Expand Down
1 change: 1 addition & 0 deletions src/pages/popup/components/PayWebsiteForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export const PayWebsiteForm = () => {
</FadeInOut>
)}

{/** biome-ignore lint/correctness/useUniqueElementIds: referenced as stable ID */}
<InputAmount
id="payAmount"
label={
Expand Down
2 changes: 2 additions & 0 deletions src/pages/popup/components/Settings/Budget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ const BudgetAmount = ({
return (
<form className="space-y-2" onSubmit={onSubmit}>
<div className="flex items-center gap-4">
{/** biome-ignore lint/correctness/useUniqueElementIds: referenced as stable ID */}
<InputAmount
id="budgetAmount"
label="Budget amount"
Expand Down Expand Up @@ -202,6 +203,7 @@ const RemainingBalance = ({
const amount = transformBalance(balance, walletAddress.assetScale);
return (
<div className="space-y-2">
{/** biome-ignore lint/correctness/useUniqueElementIds: referenced as stable ID */}
<InputAmount
id="remainingBalance"
onChange={() => {}}
Expand Down
1 change: 1 addition & 0 deletions src/pages/popup/components/Settings/RateOfPay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ const RateOfPayInput = ({
);

return (
// biome-ignore lint/correctness/useUniqueElementIds: referenced as stable ID
<InputAmount
id="rateOfPay"
className="max-w-56"
Expand Down
1 change: 1 addition & 0 deletions src/pages/popup/components/layout/MainLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ const Divider = () => {

export const MainLayout = ({ children }: { children: React.ReactNode }) => {
return (
// biome-ignore lint/correctness/useUniqueElementIds: main is unique, as at top-level layout
<div className="flex h-popup w-popup flex-col gap-4 px-6 py-4" id="main">
<Header />
<Divider />
Expand Down
1 change: 1 addition & 0 deletions src/pages/shared/components/Icons.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// biome-ignore-all lint/correctness/useUniqueElementIds: our IDs are unique here
import React from 'react';

export const Spinner = (props: React.SVGProps<SVGSVGElement>) => {
Expand Down