feat(PostInstall): add consent screen about data sharing#1191
Merged
Conversation
github-actions
Bot
added
area: pages/app
area: pages
sidvishnoi
commented
Sep 25, 2025
| ); | ||
| }; | ||
|
|
||
| const Main = () => { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
- Should "What's not shared" be a subsection of "What's shared"? It's probably more a matter of style, but I suggest making it the same level. Totally up to you.
- Under "...with wallets... that use Web Monetization", first bullet, there's a space between "information" and the period.
- I don't know if there's anything to do, but if someone is reading but not paying attention, they're going to see that their wallet address is shared with a web monetized site's wallet, then immediately see that their wallet address is not shared with websites they visit. I don't think someone new to Web Monetization will understand the difference. Just wanted to call that out.
Member
Author
There was a problem hiding this comment.
Good point on (3). I don't have any better suggestions though.
This is the latest state:
Contributor
Extension builds preview
|
github-actions
Bot
added
area: background
DarianM
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #1189
Changes proposed in this pull request