Skip to content

fix(PostInstallConsent): prevent crash in Safari on getting ext name#1209

Merged
sidvishnoi merged 1 commit into
mainfrom
safari-consent-screen
Oct 20, 2025
Merged

fix(PostInstallConsent): prevent crash in Safari on getting ext name#1209
sidvishnoi merged 1 commit into
mainfrom
safari-consent-screen

Conversation

@sidvishnoi
Copy link
Copy Markdown
Member

@sidvishnoi sidvishnoi commented Oct 19, 2025

Context

browser.management.getSelf() isn't supported in Safari.

Changes proposed in this pull request

Use browser.runtime.getManifest() to know extension's name.

@sidvishnoi sidvishnoi requested a review from DarianM October 19, 2025 11:21
@github-actions github-actions Bot added area: pages/app area: pages Changes to any of extension's pages labels Oct 19, 2025
@sidvishnoi sidvishnoi changed the title fix(PostInstallConsent): management API isn't supported in Safari fix(PostInstallConsent): prevent crash in Safari on getting ext name Oct 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Extension builds preview

Name Link
Latest commit f3111ac
Latest job logs Run #18629695034
Chrome (1011.54KB)Download
Firefox (1011.57KB)Download
Safari (1.94MB)Download

@sidvishnoi sidvishnoi merged commit 16f2323 into main Oct 20, 2025
17 of 19 checks passed
@sidvishnoi sidvishnoi deleted the safari-consent-screen branch October 20, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: pages/app area: pages Changes to any of extension's pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants