fix: remove browser name from key nickname, update consent text#1228
Merged
Conversation
Contributor
Extension builds preview
|
DarianM
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
As requested by Firefox during extension reviews:
We decided to remove the browser name from key nick name for all browsers.
Changes proposed in this pull request
There will be no changes for users who have already connected their wallet. For new users who haven't added public key to their wallet, the key nickname won't include browser name; and just say "Web Monetization". This might make it tougher for users with multiple browser installations to identify keys, but this should help with publishing to Firefox Add-ons.
Screenshots