Skip to content

fix: remove browser name from key nickname, update consent text#1228

Merged
sidvishnoi merged 2 commits into
mainfrom
key-nickname-remove-browser-name
Oct 29, 2025
Merged

fix: remove browser name from key nickname, update consent text#1228
sidvishnoi merged 2 commits into
mainfrom
key-nickname-remove-browser-name

Conversation

@sidvishnoi

@sidvishnoi sidvishnoi commented Oct 29, 2025

Copy link
Copy Markdown
Member

Context

As requested by Firefox during extension reviews:

Other, specifically Issue not covered by other reasons: In order for an extension to explicitly collect technical data (such as the extension version and browser name), an add-on must receive explicit user consent as described in the Data Collection and Transmission Disclosure and Control section of Add-ons Policies and associated best practices documentation. Implicit data transmission (such as the user agent header on an HTTP request) is not considered under this policy.

The most direct way to address this violation is to remove the browser name from the request message body and to use server-side logic to extract the browser name from the user agent header..

We decided to remove the browser name from key nick name for all browsers.

Changes proposed in this pull request

There will be no changes for users who have already connected their wallet. For new users who haven't added public key to their wallet, the key nickname won't include browser name; and just say "Web Monetization". This might make it tougher for users with multiple browser installations to identify keys, but this should help with publishing to Firefox Add-ons.

Screenshots

Before After
image image
image image

@github-actions github-actions Bot added the area: background Improvements or additions to extension background script label Oct 29, 2025
@github-actions

github-actions Bot commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

Extension builds preview

Name Link
Latest commit 2fb4a2d
Latest job logs Run #18904360295
Chrome (988.12KB)Download
Firefox (988.15KB)Download
Safari (1.91MB)Download

@RabebOthmani RabebOthmani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy looks good

@sidvishnoi sidvishnoi merged commit c96c542 into main Oct 29, 2025
15 of 16 checks passed
@sidvishnoi sidvishnoi deleted the key-nickname-remove-browser-name branch October 29, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: background Improvements or additions to extension background script area: i18n area: pages/app area: pages Changes to any of extension's pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants