Skip to content

fix(RateOfPay): correctly set min value#1240

Merged
sidvishnoi merged 2 commits into
mainfrom
RateOfPay-broken-input
Nov 24, 2025
Merged

fix(RateOfPay): correctly set min value#1240
sidvishnoi merged 2 commits into
mainfrom
RateOfPay-broken-input

Conversation

@sidvishnoi

@sidvishnoi sidvishnoi commented Nov 11, 2025

Copy link
Copy Markdown
Member

Context

With min={1} max={Number(formatAmount('100'))}, both min/max were set to 1, making input not editable.
Regressed in #1085.

Changes proposed in this pull request

Provide min is same format as we set max. Now min={0.01} correctly.

@github-actions github-actions Bot added area: popup Improvements or additions to extension popup area: pages Changes to any of extension's pages labels Nov 11, 2025
@github-actions

github-actions Bot commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Extension builds preview

Name Link
Latest commit 22e1e50
Latest job logs Run #19630406795
Chrome (988.19KB)Download
Firefox (988.22KB)Download
Safari (1.91MB)Download

@sidvishnoi sidvishnoi merged commit ae1f679 into main Nov 24, 2025
12 of 13 checks passed
@sidvishnoi sidvishnoi deleted the RateOfPay-broken-input branch November 24, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: pages Changes to any of extension's pages area: popup Improvements or additions to extension popup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants