fix(ConnectWalletForm): remove no consent error from background#1309
Merged
sidvishnoi merged 7 commits intomainfrom Feb 27, 2026
Merged
fix(ConnectWalletForm): remove no consent error from background#1309sidvishnoi merged 7 commits intomainfrom
sidvishnoi merged 7 commits intomainfrom
Conversation
github-actions
Bot
added
area: background
Contributor
Extension builds preview
|
sidvishnoi
commented
Feb 26, 2026
Comment on lines
-111
to
+123
| state?.status === 'error:key' | ||
| state?.status === 'error:key' || | ||
| (state?.status === 'error' && | ||
| typeof state.error === 'object' && | ||
| state.error?.key === 'connectWallet_error_invalidClient') | ||
| ? toErrorInfo(deepClone(state.error)) | ||
| : null, | ||
| connect: | ||
| state?.status === 'error' ? toErrorInfo(deepClone(state.error)) : null, | ||
| state?.status === 'error' && | ||
| (typeof state.error === 'object' | ||
| ? state.error.key !== 'connectWallet_error_invalidClient' | ||
| : true) | ||
| ? toErrorInfo(deepClone(state.error)) | ||
| : null, |
Member
Author
There was a problem hiding this comment.
This situation will be improved in coming follow-ups.
DarianM
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part of #1238 (trying to simplify error logic)
Part of #957
Follow up of #1308
Changes proposed in this pull request
Instead of sending a connect wallet request to background, which then throws
noConsenterror, ask for consent on client side (ConnectWalletForm) early if we know key is not added and automatic key addition is supported.Makes the flow faster, less error handling (even lesser eventually), and less "fake errors" in logs.