Skip to content

feat(PostConnect): status message copy overhaul#1327

Merged
sidvishnoi merged 2 commits intomainfrom
post-connect-error-messages-overhaul
Mar 19, 2026
Merged

feat(PostConnect): status message copy overhaul#1327
sidvishnoi merged 2 commits intomainfrom
post-connect-error-messages-overhaul

Conversation

@sidvishnoi
Copy link
Copy Markdown
Member

@sidvishnoi sidvishnoi commented Mar 19, 2026

Context

Part of #1238

Changes proposed in this pull request

Instead of using URLSearchParams for showing status messages, use TransientState for wallet status messages.
Adds more messages, hardcoded for now (follow-up will move them into locales JSON file).
Right after this PR, I'll add support for automatic retry.

To reviewer: Review the final content of PostConnect.tsx instead of trying to make sense of diff. Or, use split-diff, instead of inline.

@sidvishnoi sidvishnoi requested a review from DarianM March 19, 2026 12:00
@github-actions github-actions Bot added area: pages/app area: pages Changes to any of extension's pages area: shared Changes to shared libraries and utilities labels Mar 19, 2026
Comment thread src/shared/types.ts
* - `false`/`undefined`: cannot retry
*/
retryPossible: 'auto' | 'manual' | false;
retryMessage?: object;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be defined in follow-up.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 19, 2026

Extension builds preview

Name Link
Latest commit 97745c2
Latest job logs Run #23295683049
Chrome (1.37MB)Download
Firefox (1.37MB)Download
Safari (2.32MB)Download

@sidvishnoi sidvishnoi changed the title fix(PostConnect): status message copy overhaul feat(PostConnect): status message copy overhaul Mar 19, 2026
@sidvishnoi sidvishnoi merged commit 260149f into main Mar 19, 2026
14 checks passed
@sidvishnoi sidvishnoi deleted the post-connect-error-messages-overhaul branch March 19, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: pages/app area: pages Changes to any of extension's pages area: shared Changes to shared libraries and utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants