fix(PostConnect): move strings to _locales file#1332
Merged
sidvishnoi merged 7 commits intomainfrom Mar 24, 2026
Merged
Conversation
github-actions
Bot
added
area: i18n
area: pages/app
area: pages
Contributor
Extension builds preview
|
7 tasks
| "message": "Wallet reconnection failed" | ||
| }, | ||
| "postConnect_reconnect_failure_other_msg": { | ||
| "message": "We couldn’t verify your wallet. Please ensure the public key is added to your wallet." |
There was a problem hiding this comment.
If we're going to tell people to do something out of the ordinary--find the key and add it to their wallet--we should try to tell them how.
If this message appears on or over the screen that shows their key, then that's a little less info we need to provide.
We couldn't verify your wallet. Please copy your public key and add it to your digital wallet account.
Something like that, perhaps.
Member
Author
There was a problem hiding this comment.
If this message appears on or over the screen that shows their key, then that's a little less info we need to provide.
Can't do that without substantial changes unfortunately.
But will update message that they need to copy it manually or try again. c2a1aef
DarianM
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part of #1238
Follow-up of #1327
Changes proposed in this pull request
Move all message strings to
_locales.