fix(bg/monetization): start only after all sessions ready#1352
Merged
sidvishnoi merged 2 commits intomainfrom Apr 15, 2026
Merged
fix(bg/monetization): start only after all sessions ready#1352sidvishnoi merged 2 commits intomainfrom
sidvishnoi merged 2 commits intomainfrom
Conversation
github-actions
Bot
added
the
area: background
Contributor
Extension builds preview
|
3 tasks
3 tasks
DarianM
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Regression from #1340.
In #1340, we started monetization and updated icon/status as soon as one session was ready. This added a lot of unpredictability based on timing on each session ready, and our E2E tests are failing since then.
Changes proposed in this pull request
Start monetization only after all sessions are ready, but update icon/status as soon as possible.
Essentially, revert a part of #1340, until we figure out a better strategy to make things more robust (and add more control in E2E tests too).