Skip to content

fix(bg/paymentSession): unmark session as invalid if force reset#1357

Merged
sidvishnoi merged 1 commit intomainfrom
fix-reconnect-resume-sessions
Apr 15, 2026
Merged

fix(bg/paymentSession): unmark session as invalid if force reset#1357
sidvishnoi merged 1 commit intomainfrom
fix-reconnect-resume-sessions

Conversation

@sidvishnoi
Copy link
Copy Markdown
Member

@sidvishnoi sidvishnoi commented Apr 15, 2026

Context

Closes #1356
Part of #1355

Changes proposed in this pull request

When we resumed after a forced findMinSendAmount (when key re-added), the session was still marked as invalid, so PaymentManager iterator said: "No sessions!" error and site stayed "invalid".
Took me a while to debug!

@sidvishnoi sidvishnoi requested a review from DarianM April 15, 2026 13:03
@github-actions github-actions Bot added the area: background Improvements or additions to extension background script label Apr 15, 2026
@sidvishnoi sidvishnoi linked an issue Apr 15, 2026 that may be closed by this pull request
3 tasks
@github-actions
Copy link
Copy Markdown
Contributor

Extension builds preview

Name Link
Latest commit d4d250d
Latest job logs Run #24456059726
Chrome (1.38MB)Download
Firefox (1.38MB)Download
Safari (2.32MB)Download

@sidvishnoi sidvishnoi merged commit 4a16093 into main Apr 15, 2026
14 of 15 checks passed
@sidvishnoi sidvishnoi deleted the fix-reconnect-resume-sessions branch April 15, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: background Improvements or additions to extension background script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Monetization does not resume after key-revoke reconnect Investigate broken E2E tests

2 participants