fix(ConnectWalletForm): recheck isKeyAdded before asking#1369
Merged
sidvishnoi merged 2 commits intomainfrom May 5, 2026
Merged
fix(ConnectWalletForm): recheck isKeyAdded before asking#1369sidvishnoi merged 2 commits intomainfrom
isKeyAdded before asking#1369sidvishnoi merged 2 commits intomainfrom
Conversation
github-actions
Bot
added
area: popup
Contributor
Extension builds preview
|
DarianM
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #1366
Changes proposed in this pull request
Recheck wallet address info before asking for consent. Regressed in #1309, where to improve performance, we avoided the lookup, as user adding key from popup meant popup will be closed and we'll be automatically fetching latest info, but in app page form, we need to manually get latest info.