Handle non-trailing-slash routes as well

The "official" spec doesn't specify how to behave on a multiple-module endpoint like this one. Follow the least surprise principle and make both work.

Author: Mathieu Mitchell

tests/test_api.py

@@ -33,10 +33,13 @@ def setUp(self):
 
         self.api = Api(self.modules, self.app, self.router)
 
+    def generate_module_path(self, module_name):
+        return '/{0}/'.format(module_name)
+
     def test_list_implemented_methods(self):
         self.router.list_implemented_methods.return_value = ['abcd', 'efgh']
 
-        output = self.api_client.get('/module1/')
+        output = self.api_client.get(self.generate_module_path('module1'))
         self.router.list_implemented_methods.assert_called_with(self.module1)
 
         assert_that(json.loads(output.data.decode(output.charset)), is_({
@@ -48,7 +51,7 @@ def test_list_implemented_methods(self):
 
     def test_execute_method_returns_string(self):
         self.router.invoke_method.return_value = 'simple string'
-        output = self.api_client.post('/module2/',
+        output = self.api_client.post(self.generate_module_path('module2'),
                                       headers={'Content-Type': 'application/json'},
                                       data=json.dumps(
             {
@@ -66,7 +69,7 @@ def test_execute_method_returns_string(self):
 
     def test_execute_method_returns_list(self):
         self.router.invoke_method.return_value = ['a', 'b', 'c']
-        output = self.api_client.post('/module2/',
+        output = self.api_client.post(self.generate_module_path('module2'),
                                       headers={'Content-Type': 'application/json'},
                                       data=json.dumps(
             {
@@ -83,7 +86,7 @@ def test_execute_method_returns_list(self):
         assert_that(json.loads(output.data.decode(output.charset)), is_(['a', 'b', 'c']))
 
     def test_invoking_unknown_module_returns_a_404(self):
-        output = self.api_client.post('/new_module/',
+        output = self.api_client.post(self.generate_module_path('new_module'),
                                       headers={'Content-Type': 'application/json'},
                                       data=json.dumps(
                                           {
@@ -99,6 +102,10 @@ def test_invoking_unknown_module_returns_a_404(self):
         assert_that(output.status_code, is_(404))
 
     def test_listing_unknown_module_returns_a_404(self):
-        output = self.api_client.get('/new_module/')
+        output = self.api_client.get(self.generate_module_path('new_module'))
 
         assert_that(output.status_code, is_(404))
+
+class NoTrailingSlashApiTest(ApiTest):
+    def generate_module_path(self, module_name):
+        return '/{0}'.format(module_name)

ubersmith_remote_module_server/api.py

@@ -21,15 +21,16 @@ class Api(object):
     def __init__(self, modules, app, router):
         self.app = app
         self.router = router
+        self.app.url_map.strict_slashes = False
 
         for module_name, module in modules.items():
             list_endpoint = functools.partial(self.list_implemented_methods, module)
             list_endpoint.__name__ = "list_" + module_name
-            app.add_url_rule('/{}/'.format(module_name), view_func=list_endpoint, methods=['GET'])
+            app.add_url_rule('/{}'.format(module_name), view_func=list_endpoint, methods=['GET'])
 
             handle_endpoint = functools.partial(self.handle_remote_invocation, module)
             handle_endpoint.__name__ = "handle_" + module_name
-            app.add_url_rule('/{}/'.format(module_name), view_func=handle_endpoint, methods=['POST'])
+            app.add_url_rule('/{}'.format(module_name), view_func=handle_endpoint, methods=['POST'])
 
     def list_implemented_methods(self, module):
         methods = self.router.list_implemented_methods(module)