Merge pull request #607 from internxt/fix/sonarcloud-issues

[_]: fix/sonarcloud-issues

Author: larryrider

package-lock.json

@@ -52,6 +52,7 @@
     "dotenv": "17.4.2",
     "express": "5.2.1",
     "express-async-handler": "1.2.0",
+    "fast-xml-builder": "1.2.0",
     "fast-xml-parser": "5.9.0",
     "hash-wasm": "4.12.0",
     "mime-types": "3.0.2",
@@ -90,7 +91,7 @@
     "vitest-mock-express": "^2.2.0"
   },
   "optionalDependencies": {
-    "sharp": "^0.34.5"
+    "sharp": "0.35.1"
   },
   "engines": {
     "node": "^22.13.0 || >=24.11.0"

package.json

@@ -31,7 +31,9 @@ export class DriveFileService {
     return driveFileItem;
   };
 
-  private createDriveFileEntry = async (payload: StorageTypes.FileEntryByUuid): Promise<StorageTypes.DriveFileData> => {
+  private readonly createDriveFileEntry = async (
+    payload: StorageTypes.FileEntryByUuid,
+  ): Promise<StorageTypes.DriveFileData> => {
     const currentWorkspace = await AuthService.instance.getCurrentWorkspace();
 
     if (currentWorkspace) {

src/services/drive/drive-file.service.ts

@@ -9,7 +9,7 @@ import { DriveItemBD } from '../database/drive-item/drive-item.domain';
 export class DriveItemService {
   static readonly instance = new DriveItemService();
 
-  private tryGetFileByUuid = async (cached: DriveItemBD, path: string): Promise<DriveFileItem | undefined> => {
+  private readonly tryGetFileByUuid = async (cached: DriveItemBD, path: string): Promise<DriveFileItem | undefined> => {
     try {
       const item = await DriveFileService.instance.getFileMetadata(cached.uuid);
       await DriveItemRepository.instance.createOrUpdate([
@@ -28,7 +28,10 @@ export class DriveItemService {
     }
   };
 
-  private tryGetFolderByUuid = async (cached: DriveItemBD, path: string): Promise<DriveFolderItem | undefined> => {
+  private readonly tryGetFolderByUuid = async (
+    cached: DriveItemBD,
+    path: string,
+  ): Promise<DriveFolderItem | undefined> => {
     try {
       const item = await DriveFolderService.instance.getFolderMetaByUuid(cached.uuid);
       await DriveItemRepository.instance.createOrUpdate([

src/services/drive/drive-item.service.ts

@@ -64,7 +64,7 @@ export class ThumbnailService {
   private readonly getThumbnailFromImageBuffer = async (buffer: Buffer): Promise<Buffer | undefined> => {
     const sharp = await getSharp();
     if (sharp) {
-      return sharp(buffer, { failOnError: false })
+      return sharp(buffer, { failOn: 'none' })
         .resize({
           height: ThumbnailConfig.MaxHeight,
           width: ThumbnailConfig.MaxWidth,

src/services/thumbnail.service.ts

@@ -24,6 +24,6 @@ export class AsyncUtils {
 
     return Promise.race([promise, timeoutPromise]).finally(() => {
       clearTimeout(timeoutId);
-    }) as Promise<T>;
+    });
   };
 }

src/utils/async.utils.ts

@@ -1,4 +1,5 @@
-import { XMLParser, XMLBuilder, X2jOptions, XmlBuilderOptions } from 'fast-xml-parser';
+import { XMLParser, X2jOptions, XmlBuilderOptions } from 'fast-xml-parser';
+import XMLBuilder from 'fast-xml-builder';
 
 export class XMLUtils {
   static readonly DEFAULT_NAMESPACE_LETTER = 'D';

src/utils/xml.utils.ts

@@ -32,11 +32,9 @@ export const WebDAVAuthMiddleware = (configs: WebdavConfig): RequestHandler => {
           return sendUnauthorizedError(res, 'Authentication failed. Please check your WebDAV custom credentials.');
         } else {
           next();
-          return;
         }
       } else {
         next();
-        return;
       }
     })();
   };
@@ -52,5 +50,4 @@ const sendUnauthorizedError = (res: Response, message: string) => {
   );
 
   res.status(401).send(errorBodyXML);
-  return;
 };