feat: increase file size limits to 100 GB in NetworkFacade and related error handling

Author: larryrider

src/services/network/network-facade.service.ts

@@ -13,7 +13,7 @@ import { RangeOptions } from '../../utils/network.utils';
 import { UsageService } from '../usage.service';
 import { FormatUtils } from '../../utils/format.utils';
 
-const FORTY_GIGABYTES = 40 * 1024 * 1024 * 1024;
+const HUNDRED_GIGABYTES = 100 * 1024 * 1024 * 1024;
 
 export class NetworkFacade {
   private readonly cryptoLib: Network.Crypto;
@@ -145,8 +145,8 @@ export class NetworkFacade {
       throw new Error(`File is too big (${formattedSize} exceeds account upload limit of ${formattedLimit})`);
     }
 
-    if (size > FORTY_GIGABYTES) {
-      throw new Error('File is too big (more than 40 GB)');
+    if (size >= HUNDRED_GIGABYTES) {
+      throw new Error('File is too big (more than 100 GB)');
     }
 
     return this.environment.upload(bucketId, {

src/webdav/handlers/PUT.handler.ts

@@ -13,6 +13,7 @@ import { WebDavFolderService } from '../../services/webdav/webdav-folder.service
 import { ThumbnailUtils } from '../../utils/thumbnail.utils';
 import { ThumbnailService } from '../../services/thumbnail.service';
 import { FormatUtils } from '../../utils/format.utils';
+import { XMLUtils } from '../../utils/xml.utils';
 
 export class PUTRequestHandler implements WebDavMethodHandler {
   handle = async (req: Request, res: Response) => {
@@ -84,13 +85,39 @@ export class PUTRequestHandler implements WebDavMethodHandler {
       const networkUploadTimer = CLIUtils.timer();
       const abortable = new AbortController();
 
-      fileId = await networkFacade.uploadFile({
-        from: fileStream,
-        size: contentLength,
-        bucketId: bucket,
-        progressCallback,
-        abortSignal: abortable.signal,
-      });
+      try {
+        fileId = await networkFacade.uploadFile({
+          from: fileStream,
+          size: contentLength,
+          bucketId: bucket,
+          progressCallback,
+          abortSignal: abortable.signal,
+        });
+      } catch (e) {
+        aborted = true;
+        abortable.abort();
+        const error = e as Error;
+        if (bufferStream) {
+          req.unpipe(bufferStream);
+          bufferStream.destroy();
+        }
+        if (error.message.toLowerCase().includes('file is too big')) {
+          webdavLogger.error('[PUT] ❌ File is too big (' + FormatUtils.humanFileSize(contentLength) + ')');
+          const errorBodyXML = XMLUtils.toWebDavXML(
+            {
+              [XMLUtils.addDefaultNamespace('responsedescription')]: error.message,
+            },
+            {},
+            'error',
+          );
+          res.set('Content-Type', 'application/xml; charset="utf-8"');
+          res.status(413).send(errorBodyXML);
+          req.destroy();
+          return;
+        }
+
+        throw e;
+      }
 
       res.on('close', async () => {
         aborted = true;

src/webdav/middewares/errors.middleware.ts

@@ -26,5 +26,7 @@ export const ErrorHandlingMiddleware: ErrorRequestHandler = (err, req, res, _) =
     statusCode = err.statusCode;
   }
 
+  res.set('Content-Type', 'application/xml; charset="utf-8"');
   res.status(statusCode).send(errorBodyXML);
+  req.destroy();
 };

test/services/network/network-facade.service.test.ts

@@ -87,7 +87,7 @@ describe('Network Facade Service', () => {
     expect(mockEnvironment.upload).not.toHaveBeenCalled();
   });
 
-  it('Should throw an error when a file exceeds 40 GB', async () => {
+  it('Should throw an error when a file exceeds 100 GB', async () => {
     const mockEnvironment = {
       upload: vi.fn(),
     };
@@ -106,16 +106,16 @@ describe('Network Facade Service', () => {
     await expect(() =>
       sut.uploadFile({
         from: readStream,
-        size: 41 * 1024 * 1024 * 1024,
+        size: 101 * 1024 * 1024 * 1024,
         bucketId: 'bucket-id',
         progressCallback: vi.fn(),
       }),
-    ).rejects.toThrow('File is too big (more than 40 GB)');
+    ).rejects.toThrow('File is too big (more than 100 GB)');
 
     expect(mockEnvironment.upload).not.toHaveBeenCalled();
   });
 
-  it('Should enforce API limit over 40 GB hard cap when maxUploadFileSize is smaller', async () => {
+  it('Should enforce API limit over 100 GB hard cap when maxUploadFileSize is smaller', async () => {
     const mockEnvironment = {
       upload: vi.fn(),
     };