Skip to content

Commit 988369f

Browse files
committed
feat: add ETag header to PUT response and update tests
1 parent 928e658 commit 988369f

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

src/webdav/handlers/PUT.handler.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ export class PUTRequestHandler implements WebDavMethodHandler {
150150
`after ${CLIUtils.formatDuration(totalTime)}`,
151151
);
152152

153+
res.header('ETag', WebDavUtils.getItemETag(file));
153154
res.status(statusCode).send();
154155
};
155156
}

test/webdav/handlers/PUT.handler.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ describe('PUT request handler', () => {
7676

7777
await sut.handle(request, response);
7878
expect(response.status).toHaveBeenCalledWith(201);
79+
expect(response.header).toHaveBeenCalledWith('ETag', WebDavUtils.getItemETag(fileFixture));
7980
expect(getRequestedResourceStub).toHaveBeenCalledTimes(2);
8081
expect(getAndSearchItemFromResourceStub).toHaveBeenCalledOnce();
8182
expect(getDriveFolderFromResourceStub).toHaveBeenCalledOnce();
@@ -123,6 +124,7 @@ describe('PUT request handler', () => {
123124

124125
await sut.handle(request, response);
125126
expect(response.status).toHaveBeenCalledWith(201);
127+
expect(response.header).toHaveBeenCalledWith('ETag', WebDavUtils.getItemETag(fileFixture));
126128
expect(getRequestedResourceStub).toHaveBeenCalledTimes(2);
127129
expect(getAndSearchItemFromResourceStub).toHaveBeenCalledOnce();
128130
expect(getDriveFolderFromResourceStub).toHaveBeenCalledOnce();
@@ -171,6 +173,7 @@ describe('PUT request handler', () => {
171173

172174
await sut.handle(request, response);
173175
expect(response.status).toHaveBeenCalledWith(204);
176+
expect(response.header).toHaveBeenCalledWith('ETag', WebDavUtils.getItemETag(fileFixture));
174177
expect(getRequestedResourceStub).toHaveBeenCalledTimes(2);
175178
expect(getAndSearchItemFromResourceStub).toHaveBeenCalledOnce();
176179
expect(getDriveFolderFromResourceStub).toHaveBeenCalledOnce();

0 commit comments

Comments
 (0)