improved pm2 management

Author: larryrider

src/commands/webdav.ts

@@ -28,6 +28,7 @@ export default class Webdav extends Command {
 
     let message = '';
     let success = true;
+    await PM2Utils.connect();
     switch (args.action) {
       case 'enable': {
         message = await this.enableWebDav();
@@ -55,6 +56,7 @@ export default class Webdav extends Command {
         break;
       }
     }
+    PM2Utils.disconnect();
     return { success, message, action: args.action };
   };
 
@@ -71,7 +73,6 @@ export default class Webdav extends Command {
   private enableWebDav = async (): Promise<string> => {
     CLIUtils.doing('Starting Internxt WebDav server...');
     await DriveDatabaseManager.clean();
-    await PM2Utils.connect();
     await PM2Utils.killWebDavServer();
     await PM2Utils.startWebDavServer();
     CLIUtils.done();
@@ -98,7 +99,6 @@ export default class Webdav extends Command {
 
   private disableWebDav = async (): Promise<string> => {
     CLIUtils.doing('Stopping Internxt WebDav server...');
-    await PM2Utils.connect();
     await PM2Utils.killWebDavServer();
     CLIUtils.done();
     const message = 'Internxt WebDav server stopped successfully';
@@ -109,7 +109,6 @@ export default class Webdav extends Command {
   private restartWebDav = async (): Promise<string> => {
     CLIUtils.doing('Restarting Internxt WebDav server...');
     await DriveDatabaseManager.clean();
-    await PM2Utils.connect();
     const { status } = await PM2Utils.webdavServerStatus();
     if (status === 'online') {
       await PM2Utils.killWebDavServer();
@@ -120,14 +119,13 @@ export default class Webdav extends Command {
       return message;
     } else {
       CLIUtils.done();
-      const message = 'Internxt WebDav server is not running, cannot restart';
-      CLIUtils.error(this.log.bind(this), message);
+      const message = 'Internxt WebDav server is not running, it wont be restarted';
+      CLIUtils.warning(this.log.bind(this), message);
       return message;
     }
   };
 
   private webDAVStatus = async (): Promise<string> => {
-    await PM2Utils.connect();
     const { status } = await PM2Utils.webdavServerStatus();
     const message = `Internxt WebDAV server status: ${status}`;
     CLIUtils.log(this.log.bind(this), message);

src/utils/pm2.utils.ts

@@ -26,6 +26,40 @@ export class PM2Utils {
     });
   }
 
+  static disconnect() {
+    pm2.disconnect();
+  }
+
+  // TODO: Use this once the issue with PM2 is resolved: https://github.com/Unitech/pm2/issues/4825
+  static async clean() {
+    const list = await this.list();
+    if (list.length === 0) {
+      // There are NOT other active processes. PM2 daemon can be killed.
+      return new Promise<void>((resolve, reject) => {
+        pm2.killDaemon((err) => {
+          if (err) {
+            reject(err);
+          } else {
+            resolve();
+          }
+        });
+      });
+    }
+  }
+
+  static list(): Promise<pm2.ProcessDescription[]> {
+    return new Promise((resolve, reject) => {
+      pm2.list((err, processes) => {
+        if (err) {
+          reject(err);
+        } else {
+          // There are active processes. PM2 daemon will not be killed.
+          resolve(processes);
+        }
+      });
+    });
+  }
+
   static killWebDavServer() {
     return new Promise<void>((resolve) => {
       pm2.delete(this.WEBDAV_APP_NAME, () => {