feat(remote-sync): refactor error handling and update imports for consistency

Author: egalvis27

src/apps/main/remote-sync/patch-drive-file-response-item.ts

@@ -9,7 +9,7 @@ export function patchDriveFileResponseItem(payload: DriveFileResponseItem) {
   return {
     ...payload,
     fileId: payload.fileId ?? '',
-    size: typeof payload.size === 'string' ? parseInt(payload.size) : payload.size,
+    size: typeof payload.size === 'string' ? Number.parseInt(payload.size) : payload.size,
     name: payload.name ?? undefined,
   } as RemoteSyncedFile;
 }

src/apps/main/remote-sync/remote-sync-controller/index.test.ts

@@ -13,7 +13,7 @@ vi.mock('../../../../infra/sqlite/services/folder/create-or-update-folder-by-bat
 
 import * as uuid from 'uuid';
 import { createRemoteSyncController, CreateRemoteSyncControllerPops, RemoteSyncController } from './index';
-import { RemoteSyncErrorHandler } from '../create-remote-sync-error-handler';
+import { RemoteSyncErrorHandler } from '../remote-sync-error-handler';
 import { RemoteSyncedFile, RemoteSyncedFolder } from '../helpers';
 import { DriveServerError } from '../../../../infra/drive-server/drive-server.error';
 import { driveServerClient } from '../../../../infra/drive-server/client/drive-server.client.instance';

src/apps/main/remote-sync/remote-sync-controller/types.ts

@@ -2,7 +2,7 @@ import { SyncConfig, RemoteSyncStatus } from '../helpers';
 import { DatabaseCollectionAdapter } from '../../database/adapters/base';
 import { DriveFile } from '../../database/entities/DriveFile';
 import { DriveFolder } from '../../database/entities/DriveFolder';
-import { RemoteSyncErrorHandler } from '../create-remote-sync-error-handler';
+import { RemoteSyncErrorHandler } from '../remote-sync-error-handler';
 
 export type RemoteSyncControllerConfig = {
   fetchFilesLimitPerRequest: number;

…create-remote-sync-error-handler.test.ts …e-sync/remote-sync-error-handler.test.tssrc/apps/main/remote-sync/create-remote-sync-error-handler.test.ts renamed to src/apps/main/remote-sync/remote-sync-error-handler.test.ts src/apps/main/remote-sync/create-remote-sync-error-handler.test.ts renamed to src/apps/main/remote-sync/remote-sync-error-handler.test.ts

@@ -7,15 +7,15 @@ vi.mock('@internxt/drive-desktop-core/build/backend', () => ({
 import { logger } from '@internxt/drive-desktop-core/build/backend';
 import * as virtualDriveIssuesModule from '../issues/virtual-drive';
 import { call, partialSpyOn } from '../../../../tests/vitest/utils.helper';
-import { createRemoteSyncErrorHandler } from './create-remote-sync-error-handler';
+import { createRemoteSyncErrorHandler } from './remote-sync-error-handler';
 import {
   RemoteSyncError,
   RemoteSyncInvalidResponseError,
   RemoteSyncNetworkError,
   RemoteSyncServerError,
 } from './errors';
 
-describe('create-remote-sync-error-handler.test', () => {
+describe('remote-sync-error-handler.test', () => {
   const addVirtualDriveIssueMock = partialSpyOn(virtualDriveIssuesModule, 'addVirtualDriveIssue');
 
   beforeEach(() => {

…sync/create-remote-sync-error-handler.ts …remote-sync/remote-sync-error-handler.tssrc/apps/main/remote-sync/create-remote-sync-error-handler.ts renamed to src/apps/main/remote-sync/remote-sync-error-handler.ts src/apps/main/remote-sync/create-remote-sync-error-handler.ts renamed to src/apps/main/remote-sync/remote-sync-error-handler.ts

@@ -14,30 +14,30 @@ export type RemoteSyncErrorHandler = {
   handleSyncError: (props: HandleSyncErrorPops) => void;
 };
 
-export function createRemoteSyncErrorHandler(): RemoteSyncErrorHandler {
-  function handleSyncError({ error, syncItemType, itemName, itemCheckpoint }: HandleSyncErrorPops) {
-    const errorDetail = getRemoteSyncErrorDetail({
-      error,
-      syncItemType,
-      itemName,
-    });
+export function handleSyncError({ error, syncItemType, itemName, itemCheckpoint }: HandleSyncErrorPops) {
+  const errorDetail = getRemoteSyncErrorDetail({
+    error,
+    syncItemType,
+    itemName,
+  });
 
-    if (!errorDetail) {
-      return;
-    }
+  if (!errorDetail) {
+    return;
+  }
 
-    logger.error({
-      tag: 'SYNC-ENGINE',
-      msg: `Remote ${syncItemType} sync failed`,
-      error,
-      errorLabel: errorDetail.errorLabel,
-      itemName,
-      itemCheckpoint,
-    });
+  logger.error({
+    tag: 'SYNC-ENGINE',
+    msg: `Remote ${syncItemType} sync failed`,
+    error,
+    errorLabel: errorDetail.errorLabel,
+    itemName,
+    itemCheckpoint,
+  });
 
-    addVirtualDriveIssue(errorDetail.issue);
-  }
+  addVirtualDriveIssue(errorDetail.issue);
+}
 
+export function createRemoteSyncErrorHandler(): RemoteSyncErrorHandler {
   return {
     handleSyncError,
   };

src/apps/main/remote-sync/service.test.ts

@@ -80,7 +80,7 @@ vi.mock('./remote-sync-controller', () => ({
   createRemoteSyncController: mocks.remoteSyncControllerFactory,
 }));
 
-vi.mock('./create-remote-sync-error-handler', () => ({
+vi.mock('./remote-sync-error-handler', () => ({
   createRemoteSyncErrorHandler: vi.fn(() => ({
     handleSyncError: vi.fn(),
   })),

src/apps/main/remote-sync/service.ts

@@ -5,7 +5,7 @@ import { DriveFoldersCollection } from '../database/collections/DriveFolderColle
 import { createRemoteSyncController } from './remote-sync-controller';
 import { broadcastToWindows } from '../windows';
 import { isInitialSyncReady, setInitialSyncState } from './InitialSyncReady';
-import { createRemoteSyncErrorHandler } from './create-remote-sync-error-handler';
+import { createRemoteSyncErrorHandler } from './remote-sync-error-handler';
 import { registerRemoteSyncService } from '../../../context/shared/application/sync/remote-sync-service';
 import { toRemoteSyncFileDto } from './to-remote-sync-file-dto';
 import { toRemoteSyncFolderDto } from './to-remote-sync-folder-dto';