Feat/add option to change virtual drive path by egalvis27 · Pull Request #345 · internxt/drive-desktop-linux

egalvis27 · 2026-05-21T03:43:25Z

What is Changed / Added

Virtual Drive Root Path Selection

This PR introduces the ability for users to choose where the Internxt virtual drive is mounted on their system.

How it works

The user selects a base directory (e.g. ~/Downloads). The app always creates a fixed subfolder called Internxt Drive inside it, so the final mount point is always <base>/Internxt Drive/. This separation ensures the FUSE filesystem is isolated and never conflicts with the user's own files in the chosen folder.

The selected base path is persisted in the config store under virtualDriveRoot. The legacy syncRoot key is kept in sync for backwards compatibility with older code paths that still read it.

Remount lifecycle

Changing the root path triggers a full remount cycle orchestrated by remountVirtualDriveOnRootChange:

Stop — The running FUSE daemon receives SIGTERM. The Go process calls server.Unmount() to detach the filesystem from the kernel. If that fails (e.g. the file manager has the folder open), the daemon still exits.
Stale mount cleanup — Before deleting the old directory, fusermount3 -uz <oldPath> is issued as a lazy unmount. This forces the kernel to release the mount entry even if the daemon exited without cleanly unmounting, preventing ENOTCONN errors on subsequent filesystem operations.
Old directory removal — The previous Internxt Drive folder is deleted. Several safety guards prevent accidental deletion: the path must be non-empty, must not resolve to /, and must not resolve to the user's home directory.
Start — A new FUSE daemon is spawned with the updated INTERNXT_MOUNT environment variable pointing to the new path. The folder is created automatically if it does not exist.

Boot ID correlation

Each daemon spawn generates a random bootId (UUID). It is passed to the Go process via INTERNXT_BOOT_ID and echoed back in the POST /daemon/ready HTTP payload. The Node.js side validates that the received boot ID matches the active one before resolving the startup promise. This prevents a stale ready signal from a slow-exiting previous daemon from being mistaken for the new daemon being ready.

Concurrency guards

Both stopVirtualDriveOnce and remountVirtualDriveOnRootChange deduplicate concurrent calls via an in-flight promise. If a remount is already in progress when a second call arrives (e.g. the user clicks "Change" twice), the second caller awaits the same promise rather than starting a parallel remount. The in-flight reference is cleared in a finally block so subsequent calls can proceed normally after completion or failure.

* feat: Get Attributes operation + Electron 21 * fix: node: http

… and French locales (#301)

* feat: golang lint * feat: golang test pipeline * chore: go daemon testing * chore: testing for virtual drive module * fix: go lint workflow * fix: go lint workflow bump version * chore: lint issues in golang * fix: pr comments * fix: format

…r creation dependencies (#310)

* feat: Implement Open and OpenDir FUSE opeartions * fix:format * fix: linting warnings * fix: simplification of fuse status transport betweeen daemon and electron * chore:tests * fix:format * chore: skip unused fuseApp class test + fix test * Fix lint warning

… services, and tests (#320)

* feat: update drive destkop linux to electron 29 and node 20 * fix: add js script to import main.ts because output code is commonjs

… files

… in setup_test.go and handle-read-callback.test.ts

…bugTools

AlexisMora · 2026-06-08T14:12:57Z

+const VIRTUAL_DRIVE_FOLDER_NAME = 'Internxt Drive';
+
+function normalizePathname(pathname: string) {
+  return pathname[pathname.length - 1] === path.sep ? pathname : pathname + path.sep;


Check this sonarcloud issues

AlexisMora · 2026-06-08T16:27:35Z

 import { PATHS } from '../../../core/electron/paths';

 const VIRTUAL_DRIVE_FOLDER = PATHS.ROOT_DRIVE_FOLDER;
+const VIRTUAL_DRIVE_FOLDER_NAME = 'Internxt Drive';


Maybe this could go into the paths file

AlexisMora · 2026-06-08T16:27:58Z

 const VIRTUAL_DRIVE_FOLDER = PATHS.ROOT_DRIVE_FOLDER;
+const VIRTUAL_DRIVE_FOLDER_NAME = 'Internxt Drive';
+
+function normalizePathname(pathname: string) {


Since this functions are not exported, maybe they could go at the bottom of the file

AlexisMora · 2026-06-08T16:29:40Z

+        virtualDriveRoot: '/home/user/Internxt Drive/',
+        syncRoot: '/home/user/Internxt Drive',


So we have 2 values that point out to the same path?

I've removed the legacy key; I think someone tried to do this before, but it was left half-finished.

AlexisMora · 2026-06-08T16:30:34Z

+  for (const electronLog of getElectronLogModules()) {
+    electronLog.transports.file.resolvePathFn = (_, message) => {
+      return resolveAppLogFilePath({ logsPath, message });
+    };

-  coreElectronLog.transports.file.resolvePath = coreElectronLog.transports.file.resolvePathFn;
+    electronLog.transports.file.resolvePath = electronLog.transports.file.resolvePathFn;


Why this change is needed?

The change was made before the antivirus log issue was resolved, but it is no longer necessary

AlexisMora · 2026-06-08T16:36:20Z

@@ -0,0 +1,22 @@
+import { logger } from '@internxt/drive-desktop-core/build/backend';
+import { stopVirtualDriveOnce } from './virtual-drive.service';


Check here the sonarcloud issues

AlexisMora · 2026-06-08T16:37:55Z

+  }
+  logger.debug({ msg: '[VIRTUAL DRIVE] stopping server...' });
+  await stopFuseDaemonServer();
+  container = undefined;


Do we need this?

It's not necessary; I was testing it in another file, and when I moved this function here, it ended up staying by accident.

AlexisMora · 2026-06-08T16:51:12Z

+import { StorageFilesRepository } from '../../../../../context/storage/StorageFiles/domain/StorageFilesRepository';
+import { Container } from 'diod';
+
+export async function stopVirtualDrive({ container }: { container?: Container }) {


how different is this from the already existing stopVirtualDrive from services/virtual-drive.service.ts?

This function is the same one; it was moved from there to here.

AlexisMora · 2026-06-08T16:53:06Z

      await expect(startPromise).rejects.toThrow('fuse daemon exited before ready with code 1');
    });
+
+    it('should require a new ready signal for each restart', async () => {


This test looks weird, secondREsolved is never true?

I see why it looks a bit odd. secondResolved is intentionally checked before the second ready signal, so at that point it should still be false. After resolveDaemonReady is called with the new boot ID, secondStart resolves, which means that then callback can run and secondResolved can become true. So the behavior is correct, but I agree the test would be clearer if we also added an explicit final assertion that secondResolved becomes true.

AlexisMora · 2026-06-08T16:53:38Z

 }

 export function startDaemon(mountPoint: string): Promise<void> {
+  const bootId = randomUUID();


Why it needs to be random

The idea is that if there are simultaneous initializations, we can identify each one separately and keep only one active while blocking the others.

…rvices

…hange

sonarqubecloud · 2026-06-08T22:36:05Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Base automatically changed from feat/go-fuse-daemon to main June 1, 2026 15:20

egalvis27 marked this pull request as ready for review June 1, 2026 21:43

AlexisMora and others added 15 commits June 2, 2026 12:02

Go fuse daemon: Skeleton, mount and unix socket connection (#303)

1fe50f5

feat: Get Attributes operation + Electron 21 (#315)

dde25d1

* feat: Get Attributes operation + Electron 21 * fix: node: http

feat(localization): remove unused translations from English, Spanish,…

2b3f8b4

… and French locales (#301)

reafctor: device service.ts (#316)

13ef03f

fix: [PB-6255] implement PendingFolderCreationTracker to manage folde…

d1e3ad2

…r creation dependencies (#310)

feat: release operation + read tests (#323)

4b08293

feat: add unlink and rmdir operations with corresponding controllers,…

c731331

… services, and tests (#320)

feat: update drive destkop linux to electron 29 and node 20 (#332)

96e293a

* feat: update drive destkop linux to electron 29 and node 20 * fix: add js script to import main.ts because output code is commonjs

fix: remove process block (#336)

f197c5b

Feat/add thumnails range requests (#337)

aa9e0ae

feat: implement virtual drive root folder management

279cc3b

fix: ensure consistent formatting and add missing newlines in various…

40d118b

… files

test: update VirtualDriveRootPicker test to use translated button name

3b702db

egalvis27 force-pushed the feat/add-option-to-change-virtual-drive-path branch from 4c8f8cf to 3b702db Compare June 2, 2026 17:39

egalvis27 added 7 commits June 2, 2026 15:06

refactor: clean up package.json and operations.go, remove unused code…

3724194

… in setup_test.go and handle-read-callback.test.ts

feat: add remountVirtualDriveOnRootChange to virtual drive handlers

02afbad

refactor: format import statements for better readability in handlers.ts

cccf380

refactor: improve electron-debug initialization in setupEnvironmentDe…

f39d52a

…bugTools

Merge branch 'main' into feat/add-option-to-change-virtual-drive-path

691fb13

feat: add overrides for minimatch version in package.json

7fee726

feat: update virtual drive service to use stopVirtualDriveOnce

13bbe94

AlexisMora reviewed Jun 8, 2026

View reviewed changes

egalvis27 added 4 commits June 8, 2026 16:16

feat: remove syncRoot references and update related configurations

7c90735

feat: add option to change virtual drive path and refactor related se…

9834f71

…rvices

feat: handle error in migrateBackupEntryIfNeeded during backup path c…

be00da9

…hange

test: update service tests to use Map for state management

e15a065

AlexisMora approved these changes Jun 9, 2026

View reviewed changes

egalvis27 merged commit 122e1d2 into main Jun 9, 2026
11 checks passed

egalvis27 deleted the feat/add-option-to-change-virtual-drive-path branch June 9, 2026 16:17

		virtualDriveRoot: '/home/user/Internxt Drive/',
		syncRoot: '/home/user/Internxt Drive',

		@@ -0,0 +1,22 @@
		import { logger } from '@internxt/drive-desktop-core/build/backend';
		import { stopVirtualDriveOnce } from './virtual-drive.service';

Uh oh!

Conversation

egalvis27 commented May 21, 2026

What is Changed / Added

Virtual Drive Root Path Selection

How it works

Remount lifecycle

Boot ID correlation

Concurrency guards

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 8, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants