Feat/improve space validations#406
Conversation
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| const bytesToUpdate = Array.from(filesDiff.modified.entries()).reduce((acc, [local, remote]) => { | ||
| acc += local.size - remote.size; | ||
| const bytesToUpdate = Array.from(filesDiff.modified.entries()).reduce((acc, [local]) => { | ||
| acc += local.size; | ||
|
|
||
| return acc; | ||
| }, 0); | ||
|
|
||
| const total = bytesToUpdate + bytesToUpload; | ||
| const bytesToReserve = bytesToUpdate + bytesToUpload; | ||
|
|
||
| const validateSpaceResult = await UsageModule.validateSpace(total); | ||
| const validateSpaceResult = await UsageModule.validateSpace(bytesToReserve); |
There was a problem hiding this comment.
We changed this check to be simpler and safer:
Before, backup could pass the space check but still fail later during upload.
Now, we validate space using the real bytes we are going to upload (added + modified).
| try { | ||
| if (!Number.isFinite(desiredSpaceToUse) || desiredSpaceToUse < 0) { | ||
| return { error: new Error('Desired space to use must be a finite non-negative number') }; | ||
| } |
There was a problem hiding this comment.
This guard rejects invalid space requests early.
desiredSpaceToUse must be a finite, non-negative number; otherwise the check could return misleading results (for example with NaN, Infinity, or negative values).
Failing fast here makes space validation safer and easier to reason about.
|
1 participant
What is Changed / Added
Why