Skip to content

Commit 55c1608

Browse files
authored
fix: use folder uuid instead of id when looking for existent files (#1003)
1 parent 57f411b commit 55c1608

4 files changed

Lines changed: 65 additions & 68 deletions

File tree

src/modules/file/file.repository.spec.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ describe('FileRepository', () => {
147147
});
148148
});
149149

150-
describe('findByPlainNameAndFolderId', () => {
150+
describe('findByPlainNameAndFolder', () => {
151151
it('When file is searched with empty type, it should find it', async () => {
152152
const mockFile = newFile({ attributes: { type: '' } });
153153

@@ -160,11 +160,11 @@ describe('FileRepository', () => {
160160

161161
jest.spyOn(fileModel, 'findOne').mockResolvedValueOnce(model);
162162

163-
await repository.findByPlainNameAndFolderId(
163+
await repository.findByPlainNameAndFolder(
164164
mockFile.userId,
165165
mockFile.plainName,
166166
mockFile.type,
167-
mockFile.folderId,
167+
mockFile.folderUuid,
168168
mockFile.status,
169169
);
170170

@@ -173,7 +173,7 @@ describe('FileRepository', () => {
173173
userId: { [Op.eq]: mockFile.userId },
174174
plainName: { [Op.eq]: mockFile.plainName },
175175
type: { [Op.or]: [{ [Op.is]: null }, { [Op.eq]: '' }] },
176-
folderId: { [Op.eq]: mockFile.folderId },
176+
folderUuid: { [Op.eq]: mockFile.folderUuid },
177177
status: { [Op.eq]: mockFile.status },
178178
}),
179179
});
@@ -191,11 +191,11 @@ describe('FileRepository', () => {
191191

192192
jest.spyOn(fileModel, 'findOne').mockResolvedValueOnce(model);
193193

194-
await repository.findByPlainNameAndFolderId(
194+
await repository.findByPlainNameAndFolder(
195195
mockFile.userId,
196196
mockFile.plainName,
197197
mockFile.type,
198-
mockFile.folderId,
198+
mockFile.folderUuid,
199199
mockFile.status,
200200
);
201201

@@ -204,7 +204,7 @@ describe('FileRepository', () => {
204204
userId: { [Op.eq]: mockFile.userId },
205205
plainName: { [Op.eq]: mockFile.plainName },
206206
type: { [Op.or]: [{ [Op.is]: null }, { [Op.eq]: '' }] },
207-
folderId: { [Op.eq]: mockFile.folderId },
207+
folderUuid: { [Op.eq]: mockFile.folderUuid },
208208
status: { [Op.eq]: mockFile.status },
209209
}),
210210
});
@@ -222,11 +222,11 @@ describe('FileRepository', () => {
222222

223223
jest.spyOn(fileModel, 'findOne').mockResolvedValueOnce(model);
224224

225-
await repository.findByPlainNameAndFolderId(
225+
await repository.findByPlainNameAndFolder(
226226
mockFile.userId,
227227
mockFile.plainName,
228228
mockFile.type,
229-
mockFile.folderId,
229+
mockFile.folderUuid,
230230
mockFile.status,
231231
);
232232

@@ -235,7 +235,7 @@ describe('FileRepository', () => {
235235
userId: { [Op.eq]: mockFile.userId },
236236
plainName: { [Op.eq]: mockFile.plainName },
237237
type: { [Op.eq]: mockFile.type },
238-
folderId: { [Op.eq]: mockFile.folderId },
238+
folderUuid: { [Op.eq]: mockFile.folderUuid },
239239
status: { [Op.eq]: mockFile.status },
240240
}),
241241
});

src/modules/file/file.repository.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,11 @@ export interface FileRepository {
9191
folderId: Folder['uuid'],
9292
searchBy: { plainName: File['plainName']; type?: File['type'] }[],
9393
): Promise<File[]>;
94-
findByPlainNameAndFolderId(
94+
findByPlainNameAndFolder(
9595
userId: File['userId'],
9696
plainName: FileAttributes['plainName'],
9797
type: FileAttributes['type'],
98-
folderId: FileAttributes['folderId'],
98+
folderUuid: FileAttributes['folderUuid'],
9999
status: FileAttributes['status'],
100100
): Promise<File | null>;
101101
getSumSizeOfFilesInWorkspaceByStatuses(
@@ -328,11 +328,11 @@ export class SequelizeFileRepository implements FileRepository {
328328
return file ? this.toDomain(file) : null;
329329
}
330330

331-
async findByPlainNameAndFolderId(
331+
async findByPlainNameAndFolder(
332332
userId: FileAttributes['userId'],
333333
plainName: FileAttributes['plainName'],
334334
type: FileAttributes['type'],
335-
folderId: FileAttributes['folderId'],
335+
folderUuid: FileAttributes['folderUuid'],
336336
status: FileAttributes['status'],
337337
): Promise<File | null> {
338338
const typeCondition =
@@ -345,7 +345,7 @@ export class SequelizeFileRepository implements FileRepository {
345345
userId: { [Op.eq]: userId },
346346
plainName: { [Op.eq]: plainName },
347347
type: typeCondition,
348-
folderId: { [Op.eq]: folderId },
348+
folderUuid: { [Op.eq]: folderUuid },
349349
status: { [Op.eq]: status },
350350
},
351351
});

0 commit comments

Comments
 (0)