[PB-6052] chore: use a getter to set encrypted name#1005
Merged
Conversation
…igure get/set to calculate the encrypted name on the fly
apsantiso
force-pushed
the
chore/set-encrypted-name-on-the-fly
branch
from
681b550 to
4c21a69
Compare
|
sg-gs
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're planning to remove the column 'name'.
As a first step, compute name on-the-fly from plainName + folderId using AesService, so clients reading name continue to work after the column is gone.
Once we made sure that the calculated 'name' is working correctly, we need to open a PR setting the field as 'virtual' so no INSERT/UPDATEs are made on the column.
What changes: