refactor: update StalwartAccountProvider and StalwartService for account management

- Migrated to use stalwarts jmap management api
- Enhanced createAccount method to resolve domain and create accounts with proper error handling.
- Updated deleteAccount method to use email for account deletion.
- Refactored getAccount method to retrieve account information by email, returning structured data.
- Adjusted tests to reflect changes in account creation and retrieval logic, ensuring proper error handling for domain resolution and account existence.

Author: jzunigax2

src/modules/infrastructure/stalwart/stalwart-account.provider.spec.ts

@@ -2,7 +2,7 @@ import { describe, it, expect, beforeEach } from 'vitest';
 import { Test, type TestingModule } from '@nestjs/testing';
 import { createMock, type DeepMocked } from '@golevelup/ts-vitest';
 import { StalwartAccountProvider } from './stalwart-account.provider.js';
-import { StalwartService } from './stalwart.service.js';
+import { StalwartApiError, StalwartService } from './stalwart.service.js';
 import { newCreateAccountParams } from '../../../../test/fixtures.js';
 
 describe('StalwartAccountProvider', () => {
@@ -21,29 +21,47 @@ describe('StalwartAccountProvider', () => {
   });
 
   describe('createAccount', () => {
-    it('when called, then creates principal with correct shape', async () => {
-      const params = newCreateAccountParams();
+    it('when called, then resolves the domain and creates the account', async () => {
+      const params = newCreateAccountParams({
+        primaryAddress: 'alice@example.com',
+      });
+      stalwart.resolveDomainId.mockResolvedValue('dom1');
 
       await provider.createAccount(params);
 
-      expect(stalwart.createPrincipal).toHaveBeenCalledWith({
-        type: 'individual',
-        name: params.primaryAddress,
+      expect(stalwart.resolveDomainId).toHaveBeenCalledWith('example.com');
+      expect(stalwart.createAccount).toHaveBeenCalledWith({
+        name: 'alice',
+        domainId: 'dom1',
         description: params.displayName,
-        secrets: [params.password],
-        emails: [params.primaryAddress],
-        quota: 0,
-        roles: ['user'],
+        password: params.password,
+        quotaBytes: params.quota ?? 0,
+      });
+    });
+
+    it('when domain is not configured, then throws and does not create', async () => {
+      const params = newCreateAccountParams({
+        primaryAddress: 'alice@unknown.com',
       });
+      stalwart.resolveDomainId.mockResolvedValue(null);
+
+      await expect(provider.createAccount(params)).rejects.toThrow(
+        StalwartApiError,
+      );
+      expect(stalwart.createAccount).not.toHaveBeenCalled();
     });
 
     it('when quota is undefined, then defaults to 0', async () => {
-      const params = newCreateAccountParams({ quota: undefined });
+      const params = newCreateAccountParams({
+        primaryAddress: 'alice@example.com',
+        quota: undefined,
+      });
+      stalwart.resolveDomainId.mockResolvedValue('dom1');
 
       await provider.createAccount(params);
 
-      expect(stalwart.createPrincipal).toHaveBeenCalledWith(
-        expect.objectContaining({ quota: 0 }),
+      expect(stalwart.createAccount).toHaveBeenCalledWith(
+        expect.objectContaining({ quotaBytes: 0 }),
       );
     });
   });
@@ -52,50 +70,57 @@ describe('StalwartAccountProvider', () => {
     it('when called, then delegates to stalwart service', async () => {
       await provider.deleteAccount('user@example.com');
 
-      expect(stalwart.deletePrincipal).toHaveBeenCalledWith('user@example.com');
+      expect(stalwart.deleteAccountByEmail).toHaveBeenCalledWith(
+        'user@example.com',
+      );
     });
   });
 
   describe('getAccount', () => {
-    it('when principal exists, then returns account info', async () => {
-      stalwart.getPrincipal.mockResolvedValue({
-        name: 'user@example.com',
-        type: 'individual',
+    it('when account exists, then returns AccountInfo with full email as name', async () => {
+      stalwart.getAccountByEmail.mockResolvedValue({
+        id: 'acc1',
+        '@type': 'User',
+        name: 'user',
+        emailAddress: 'user@example.com',
+        domainId: 'dom1',
         description: 'User Name',
-        emails: ['user@example.com', 'alias@example.com'],
-        quota: 5_000_000,
+        quotas: { maxDiskQuota: 5_000_000 },
       });
 
       const result = await provider.getAccount('user@example.com');
 
       expect(result).toEqual({
         name: 'user@example.com',
         displayName: 'User Name',
-        emails: ['user@example.com', 'alias@example.com'],
+        emails: ['user@example.com'],
         quota: 5_000_000,
       });
     });
 
-    it('when principal does not exist, then returns null', async () => {
-      stalwart.getPrincipal.mockResolvedValue(null);
+    it('when account does not exist, then returns null', async () => {
+      stalwart.getAccountByEmail.mockResolvedValue(null);
 
       const result = await provider.getAccount('nonexistent@example.com');
 
       expect(result).toBeNull();
     });
 
-    it('when principal has no optional fields, then uses defaults', async () => {
-      stalwart.getPrincipal.mockResolvedValue({
-        name: 'user@example.com',
-        type: 'individual',
+    it('when account has no optional fields, then uses defaults', async () => {
+      stalwart.getAccountByEmail.mockResolvedValue({
+        id: 'acc1',
+        '@type': 'User',
+        name: 'user',
+        emailAddress: 'user@example.com',
+        domainId: 'dom1',
       });
 
       const result = await provider.getAccount('user@example.com');
 
       expect(result).toEqual({
         name: 'user@example.com',
         displayName: '',
-        emails: [],
+        emails: ['user@example.com'],
         quota: 0,
       });
     });

src/modules/infrastructure/stalwart/stalwart-account.provider.ts

@@ -4,7 +4,11 @@ import type {
   AccountInfo,
   CreateAccountParams,
 } from '../../account/account.types.js';
-import { StalwartService } from './stalwart.service.js';
+import {
+  StalwartApiError,
+  StalwartService,
+  splitEmail,
+} from './stalwart.service.js';
 
 @Injectable()
 export class StalwartAccountProvider extends AccountProvider {
@@ -15,33 +19,40 @@ export class StalwartAccountProvider extends AccountProvider {
   }
 
   async createAccount(params: CreateAccountParams): Promise<void> {
-    await this.stalwart.createPrincipal({
-      type: 'individual',
-      name: params.primaryAddress,
+    const { local, domain } = splitEmail(params.primaryAddress);
+    const domainId = await this.stalwart.resolveDomainId(domain);
+    if (!domainId) {
+      throw new StalwartApiError(
+        `Cannot create account: domain '${domain}' is not configured in Stalwart`,
+        { domain },
+      );
+    }
+
+    await this.stalwart.createAccount({
+      name: local,
+      domainId,
       description: params.displayName,
-      secrets: [params.password],
-      emails: [params.primaryAddress],
-      quota: params.quota ?? 0,
-      roles: ['user'],
+      password: params.password,
+      quotaBytes: params.quota ?? 0,
     });
 
     this.logger.log(`Created account '${params.primaryAddress}'`);
   }
 
-  async deleteAccount(name: string): Promise<void> {
-    await this.stalwart.deletePrincipal(name);
-    this.logger.log(`Deleted account '${name}'`);
+  async deleteAccount(email: string): Promise<void> {
+    await this.stalwart.deleteAccountByEmail(email);
+    this.logger.log(`Deleted account '${email}'`);
   }
 
-  async getAccount(name: string): Promise<AccountInfo | null> {
-    const principal = await this.stalwart.getPrincipal(name);
-    if (!principal) return null;
+  async getAccount(email: string): Promise<AccountInfo | null> {
+    const account = await this.stalwart.getAccountByEmail(email);
+    if (!account) return null;
 
     return {
-      name: principal.name,
-      displayName: principal.description ?? '',
-      emails: principal.emails ?? [],
-      quota: principal.quota ?? 0,
+      name: account.emailAddress,
+      displayName: account.description ?? '',
+      emails: [account.emailAddress],
+      quota: account.quotas?.maxDiskQuota ?? 0,
     };
   }
 }