Skip to content

Ensure cookies are always fresh before starting a Lite Terminal #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isc-bsaviano merged 1 commit into from
Jun 3, 2026
Merged

Ensure cookies are always fresh before starting a Lite Terminal #1793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/commands/webSocketTerminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ export async function launchWebSocketTerminal(targetUri?: vscode.Uri, nsOverride
}
const api = new AtelierAPI(targetUri);

// Guarantee we know the apiVersion of the server
// Guarantee that we know the apiVersion of the server and that cookies are fresh
await api.serverInfo();

// Get the terminal configuration
Expand All @@ -814,8 +814,11 @@ export class WebSocketTerminalProfileProvider implements vscode.TerminalProfileP
const uri: vscode.Uri = await getWsServerConnection("2023.2.0");

if (uri) {
const api = new AtelierAPI(uri);
// Ensure cookies aren't stale because a 401 error will kill the terminal with no error log
await api.serverInfo();
// Get the terminal configuration. Will throw if there's an error.
const terminalOpts = terminalConfigForUri(new AtelierAPI(uri), uri, true);
const terminalOpts = terminalConfigForUri(api, uri, true);
return new vscode.TerminalProfile(terminalOpts);
} else if (uri === undefined) {
throw new Error(NO_ELIGIBLE_CONNECTIONS);
Expand Down