Skip to content

Commit 1600900

Browse files
committed
Address review comments
1 parent cfd89a3 commit 1600900

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/cls/IPM/Main.cls

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2269,7 +2269,7 @@ ClassMethod ShowModulesForRepository(
22692269
set server = ##class(%IPM.Repo.Definition).ServerDefinitionKeyOpen(pRepoName,,.tSC)
22702270
$$$ThrowOnError(tSC)
22712271
if server.%IsA("%IPM.Repo.Filesystem.Definition") {
2272-
write !,"Last full cache rebuild for '", pRepoName, "' was on ", server.CacheLastRebuilt, " (UTC). Run 'repo -n "_pRepoName_" -rebuild-cache' to refresh the cache.",!
2272+
write !,"Last full cache rebuild for '", pRepoName, "' was on ", server.CacheLastRebuilt, " (UTC). If needed, run 'repo -n "_pRepoName_" -rebuild-cache' to refresh the cache.",!
22732273
}
22742274
}
22752275

src/cls/IPM/Repo/Filesystem/Cache.cls

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,14 @@ ClassMethod RootNameVersionOpenValidated(
139139
try {
140140
// Open the cache entry
141141
set cacheObj = ..RootNameVersionOpen(root, name, versionString, concurrency, .status)
142-
$$$ThrowOnError(status)
142+
if $$$ISERR(status) {
143+
quit
144+
}
143145

144146
set defObj = ##class(%IPM.Repo.Filesystem.Definition).RootIndexOpen(root, , .status)
145-
$$$ThrowOnError(status)
147+
if $$$ISERR(status) {
148+
quit
149+
}
146150

147151
// Check for schema migration (old cache entries without FileMTime)
148152
set dirPath = ##class(%File).NormalizeFilename(cacheObj.SubDirectory, cacheObj.Root)
@@ -153,7 +157,6 @@ ClassMethod RootNameVersionOpenValidated(
153157
set horologTime = ##class(%Library.File).GetFileDateModified(filePath)
154158
set currentMTime = $zdatetime(horologTime, 3)
155159
do defObj.RefreshCacheEntry(cacheObj, filePath, currentMTime)
156-
$$$ThrowOnError(status)
157160
} else {
158161
// File doesn't exist - invalidate cache
159162
set status = $$$ERROR($$$GeneralError, "module.xml not found in " _ dirPath)
@@ -178,9 +181,6 @@ ClassMethod RootNameVersionOpenValidated(
178181
// Compare cached mtime with current mtime
179182
if (cacheObj.FileMTime '= currentMTime) {
180183
do defObj.RefreshCacheEntry(cacheObj, filePath, currentMTime)
181-
if $$$ISERR(status) {
182-
quit
183-
}
184184
}
185185
} catch ex {
186186
set status = ex.AsStatus()

0 commit comments

Comments
 (0)