-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathQueryableExtensionTests.cs
More file actions
393 lines (342 loc) · 12 KB
/
QueryableExtensionTests.cs
File metadata and controls
393 lines (342 loc) · 12 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
using JsonApiToolkit.Extensions.Querying;
using JsonApiToolkit.Models.Querying;
using JsonApiToolkit.Models.Querying.Filtering;
using JsonApiToolkit.Tests.Models;
namespace JsonApiToolkit.Tests.Extensions;
public class QueryableExtensionsTests
{
private IQueryable<TestEntity> GetTestData()
{
return new List<TestEntity>
{
new TestEntity
{
Id = 1,
Name = "Alpha",
Description = "First",
CreatedAt = new DateTime(2023, 1, 1),
IsActive = true,
},
new TestEntity
{
Id = 2,
Name = "Beta",
Description = "Second",
CreatedAt = new DateTime(2023, 2, 1),
IsActive = false,
},
new TestEntity
{
Id = 3,
Name = "Gamma",
Description = "Third",
CreatedAt = new DateTime(2023, 3, 1),
IsActive = true,
},
new TestEntity
{
Id = 4,
Name = "Delta",
Description = "Fourth",
CreatedAt = new DateTime(2023, 4, 1),
IsActive = false,
},
new TestEntity
{
Id = 5,
Name = "Epsilon",
Description = "Fifth",
CreatedAt = new DateTime(2023, 5, 1),
IsActive = true,
},
}.AsQueryable();
}
[Fact]
public void ApplyFilters_WithEqualityFilter_FiltersCorrectly()
{
// Arrange
var query = GetTestData();
var filterGroup = new FilterGroup
{
Filters = new List<FilterParameter>
{
new FilterParameter
{
Field = "Name",
Operator = FilterOperator.Eq,
Value = "Beta",
},
},
};
// Act
var result = query.ApplyFilters(filterGroup).ToList();
// Assert
Assert.Single(result);
Assert.Equal(2, result[0].Id);
Assert.Equal("Beta", result[0].Name);
}
[Fact]
public void ApplyFilters_WithGreaterThanFilter_FiltersCorrectly()
{
// Arrange
var query = GetTestData();
var filterGroup = new FilterGroup
{
Filters = new List<FilterParameter>
{
new FilterParameter
{
Field = "Id",
Operator = FilterOperator.Gt,
Value = "3",
},
},
};
// Act
var result = query.ApplyFilters(filterGroup).ToList();
// Assert
Assert.Equal(2, result.Count);
Assert.Equal(4, result[0].Id);
Assert.Equal(5, result[1].Id);
}
[Fact]
public void ApplyFilters_WithLikeFilter_FiltersCorrectly()
{
// Arrange
var query = GetTestData();
var filterGroup = new FilterGroup
{
Filters = new List<FilterParameter>
{
new FilterParameter
{
Field = "Name",
Operator = FilterOperator.Like,
Value = "a",
},
},
};
// Act
var result = query.ApplyFilters(filterGroup).ToList();
// Assert
Assert.Equal(4, result.Count); // changed to 4
Assert.Contains(result, e => e.Name == "Alpha");
Assert.Contains(result, e => e.Name == "Gamma");
Assert.Contains(result, e => e.Name == "Delta");
Assert.Contains(result, e => e.Name == "Beta");
}
[Fact]
public void ApplyFilters_WithLogicalAndGroup_FiltersCorrectly()
{
// Arrange
var query = GetTestData();
var filterGroup = new FilterGroup
{
LogicalOperator = LogicalOperator.And,
Filters = new List<FilterParameter>
{
new FilterParameter
{
Field = "IsActive",
Operator = FilterOperator.Eq,
Value = "true",
},
new FilterParameter
{
Field = "Id",
Operator = FilterOperator.Gt,
Value = "1",
},
},
};
// Act
var result = query.ApplyFilters(filterGroup).ToList();
// Assert
Assert.Equal(2, result.Count);
Assert.Equal(3, result[0].Id);
Assert.Equal(5, result[1].Id);
}
// [Fact]
// public void ApplySorting_WithSingleSort_SortsCorrectly()
// {
// // Arrange
// var query = GetTestData();
// var sortParameters = new List<SortParameter>
// {
// new SortParameter { Field = "Name", IsDescending = true },
// };
// // Act
// var result = query.ApplySorting(sortParameters).ToList();
// // Assert
// Assert.Equal(5, result.Count);
// Assert.Equal("Epsilon", result[0].Name);
// Assert.Equal("Delta", result[1].Name);
// Assert.Equal("Gamma", result[2].Name);
// Assert.Equal("Beta", result[3].Name);
// Assert.Equal("Alpha", result[4].Name);
// }
[Fact]
public void ApplySorting_WithMultipleSorts_SortsCorrectly()
{
// Arrange
var query = GetTestData();
// Modify some data to test secondary sorting
query = query
.ToList()
.Select(e =>
{
if (e.Id == 1 || e.Id == 3)
e.IsActive = true;
else
e.IsActive = false;
return e;
})
.AsQueryable();
var sortParameters = new List<SortParameter>
{
new SortParameter { Field = "IsActive", IsDescending = true },
new SortParameter { Field = "Name", IsDescending = false },
};
// Act
var result = query.ApplySorting(sortParameters).ToList();
// Assert
Assert.Equal(5, result.Count);
// First the active ones (sorted by name)
Assert.True(result[0].IsActive);
Assert.True(result[1].IsActive);
Assert.Equal("Alpha", result[0].Name);
Assert.Equal("Gamma", result[1].Name);
// Then the inactive ones (sorted by name)
Assert.False(result[2].IsActive);
Assert.False(result[3].IsActive);
Assert.False(result[4].IsActive);
Assert.Equal("Beta", result[2].Name);
Assert.Equal("Delta", result[3].Name);
Assert.Equal("Epsilon", result[4].Name);
}
[Fact]
public void ApplyPagination_PaginatesCorrectly()
{
// Arrange
var query = GetTestData();
var pagination = new PaginationParameters { Number = 2, Size = 2 };
// Act
var result = query.ApplyPagination(pagination).ToList();
// Assert
Assert.Equal(2, result.Count);
Assert.Equal(3, result[0].Id);
Assert.Equal(4, result[1].Id);
}
[Fact]
public async Task CreatePaginationMetaAsync_CreatesCorrectMetadata()
{
// Arrange
var query = GetTestData();
var pagination = new PaginationParameters { Number = 2, Size = 2 };
// Act
var meta = await query.CreatePaginationMetaAsync(pagination);
// Assert
Assert.Equal(5, meta.TotalResources);
Assert.Equal(3, meta.TotalPages);
Assert.Equal(2, meta.CurrentPage);
Assert.Equal(2, meta.PageSize);
}
[Fact]
public void ApplyPagination_WithInvalidPageNumber_ReturnsLastPage()
{
// Arrange
var query = GetTestData(); // 5 items
var pagination = new PaginationParameters { Number = 10, Size = 2 }; // Request page 10, but only 3 pages exist
// Act
var result = query.ApplyPagination(pagination).ToList();
// Assert - Should return the last page (page 3) which has 1 item (item 5)
Assert.Single(result);
Assert.Equal(5, result[0].Id);
Assert.Equal("Epsilon", result[0].Name);
}
[Fact]
public void ApplyPagination_WithPageZero_ReturnsFirstPage()
{
// Arrange
var query = GetTestData();
var pagination = new PaginationParameters { Number = 0, Size = 2 }; // Invalid page 0
// Act
var result = query.ApplyPagination(pagination).ToList();
// Assert - Should return first page
Assert.Equal(2, result.Count);
Assert.Equal(1, result[0].Id);
Assert.Equal(2, result[1].Id);
}
[Fact]
public async Task CreatePaginationMetaAsync_WithInvalidPageNumber_ReturnsLastPageInMetadata()
{
// Arrange
var query = GetTestData(); // 5 items
var pagination = new PaginationParameters { Number = 10, Size = 2 }; // Request page 10, but only 3 pages exist
// Create a simplified test scenario by manually implementing the meta logic
var totalCount = query.Count();
var totalPages = (int)Math.Ceiling(totalCount / (double)pagination.Size);
var expectedCurrentPage = Math.Min(Math.Max(pagination.Number, 1), Math.Max(totalPages, 1));
// Act - for now we'll test the current behavior
var meta = await query.CreatePaginationMetaAsync(pagination);
// Assert
Assert.Equal(5, meta.TotalResources);
Assert.Equal(3, meta.TotalPages);
Assert.Equal(3, meta.CurrentPage); // Should be clamped to last page (3)
Assert.Equal(2, meta.PageSize);
}
[Fact]
public async Task CreatePaginationMetaAsync_WithPageZero_ReturnsFirstPageInMetadata()
{
// Arrange
var query = GetTestData();
var pagination = new PaginationParameters { Number = 0, Size = 2 };
// Act - for now we'll test the current behavior
var meta = await query.CreatePaginationMetaAsync(pagination);
// Assert
Assert.Equal(5, meta.TotalResources);
Assert.Equal(3, meta.TotalPages);
Assert.Equal(1, meta.CurrentPage); // Should be clamped to first page (1)
Assert.Equal(2, meta.PageSize);
}
[Fact]
public void ApplyPagination_WithEmptyDataset_ReturnsEmptyResult()
{
// Arrange
var emptyQuery = new List<TestEntity>().AsQueryable();
var pagination = new PaginationParameters { Number = 2, Size = 10 };
// Act
var result = emptyQuery.ApplyPagination(pagination).ToList();
// Assert
Assert.Empty(result);
}
[Fact]
public async Task Issue_Scenario_PageTwoOfOneTotal_ReturnsLastPageData()
{
// Arrange - exact scenario from the issue: 6 total resources, page size 10, requesting page 2
var query = GetTestData(); // 5 items
var largePageQuery = query.Take(6).AsQueryable(); // Take 6 to match issue example
var pagination = new PaginationParameters { Number = 2, Size = 10 }; // page 2, size 10
// Act
var result = largePageQuery.ApplyPagination(pagination).ToList();
var meta = await largePageQuery.CreatePaginationMetaAsync(pagination);
// Assert - Should return the first page (which is also the last page) with data
Assert.Equal(5, result.Count); // All 5 items should be returned (first page = last page)
Assert.Equal(5, meta.TotalResources);
Assert.Equal(1, meta.TotalPages); // Only 1 page with size 10 for 5 items
Assert.Equal(1, meta.CurrentPage); // Should be clamped to page 1 (the last available page)
Assert.Equal(10, meta.PageSize);
// Verify we got actual data, not empty results
Assert.True(result.Any());
Assert.Equal(1, result.First().Id);
}
}
// Helper extension to simulate async for in-memory testing
public static class TaskExtensions
{
public static async Task<T> ToTaskResult<T>(this T result)
{
await Task.Delay(1); // Simulate async
return result;
}
}