Skip to content

Commit 1640232

Browse files
committed
Isolate Windows dockerd subnet; move tests
1 parent 092959a commit 1640232

File tree

7 files changed

+20
-8
lines changed

7 files changed

+20
-8
lines changed

src/main/java/io/github/intisy/docker/WindowsDockerProvider.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -741,8 +741,9 @@ private void startWsl2Docker() throws IOException, InterruptedException {
741741

742742
String isolationFlags = "";
743743
if (otherDockerdRunning) {
744-
log.info("Another Docker daemon detected, using isolation flags to avoid conflicts");
745-
isolationFlags = " --iptables=false";
744+
int subnetId = 18 + Math.abs(instanceId.hashCode() % 14);
745+
log.info("Another Docker daemon detected, using isolated subnet 172.{}.0.0/16", subnetId);
746+
isolationFlags = " --bip=172." + subnetId + ".0.1/16";
746747
}
747748

748749
log.debug("Starting dockerd directly...");

src/test/java/io/github/intisy/docker/ContainerTest.java renamed to src/test/java/io/github/intisy/docker/integration/ContainerTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package io.github.intisy.docker;
1+
package io.github.intisy.docker.integration;
22

3+
import io.github.intisy.docker.DockerClient;
4+
import io.github.intisy.docker.DockerProvider;
35
import io.github.intisy.docker.command.network.CreateNetworkCmd;
46
import io.github.intisy.docker.command.volume.ListVolumesCmd;
57
import io.github.intisy.docker.WindowsDockerProvider;

src/test/java/io/github/intisy/docker/MultiInstanceTest.java renamed to src/test/java/io/github/intisy/docker/integration/MultiInstanceTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package io.github.intisy.docker;
1+
package io.github.intisy.docker.integration;
22

3+
import io.github.intisy.docker.DockerClient;
4+
import io.github.intisy.docker.DockerProvider;
35
import io.github.intisy.docker.model.CreateContainerResponse;
46
import org.junit.jupiter.api.*;
57
import org.junit.jupiter.api.Tag;

src/test/java/io/github/intisy/docker/NvidiaToolkitTest.java renamed to src/test/java/io/github/intisy/docker/integration/NvidiaToolkitTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
package io.github.intisy.docker;
1+
package io.github.intisy.docker.integration;
22

3+
import io.github.intisy.docker.DockerClient;
4+
import io.github.intisy.docker.WindowsDockerProvider;
35
import io.github.intisy.docker.model.CreateContainerResponse;
46
import org.junit.jupiter.api.*;
57
import org.junit.jupiter.api.Tag;

src/test/java/io/github/intisy/docker/DockerClientBuilderTest.java renamed to src/test/java/io/github/intisy/docker/unit/DockerClientBuilderTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
package io.github.intisy.docker;
1+
package io.github.intisy.docker.unit;
22

3+
import io.github.intisy.docker.DockerClient;
34
import org.junit.jupiter.api.*;
45
import org.junit.jupiter.api.Tag;
56

src/test/java/io/github/intisy/docker/DockerProviderTest.java renamed to src/test/java/io/github/intisy/docker/unit/DockerProviderTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
1-
package io.github.intisy.docker;
1+
package io.github.intisy.docker.unit;
22

3+
import io.github.intisy.docker.DockerProvider;
4+
import io.github.intisy.docker.LinuxDockerProvider;
5+
import io.github.intisy.docker.MacDockerProvider;
6+
import io.github.intisy.docker.WindowsDockerProvider;
37
import org.junit.jupiter.api.*;
48
import org.junit.jupiter.api.Tag;
59

src/test/java/io/github/intisy/docker/ModelTest.java renamed to src/test/java/io/github/intisy/docker/unit/ModelTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package io.github.intisy.docker;
1+
package io.github.intisy.docker.unit;
22

33
import io.github.intisy.docker.model.*;
44
import org.junit.jupiter.api.*;

0 commit comments

Comments
 (0)